Skip to content

Bad type annotation for set_key_callback_async (trivially fixed, happy to send a PR) #171

@egnor

Description

@egnor

Describe the bug
The type anotation for set_key_callback_async

def set_key_callback_async(self, async_callback: KeyCallback, loop=None):

says async_callback: KeyCallback, but that's the type of a synchronous callback, not an async callback. I think this applies to other async callbacks as well.

To Reproduce
Write a trivial program to use set_key_async_callback and run mypy.

StreamDeck Information
(Applies to any model StreamDeck)

System Information
Applies to any OS and hardware. This is true as of library version 0.9.8, and in the current tip of github.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions