Skip to content

Commit b923405

Browse files
committed
refactor(devtools): standardize capitalization and improve formatting in SEO tab components
This commit updates the SEO tab components by standardizing the capitalization of section titles and improving code formatting for better readability. Changes include updating button labels to 'SEO Overview' and 'Social Previews', as well as enhancing the structure of JSX elements for consistency. These adjustments aim to enhance the overall clarity and maintainability of the code.
1 parent 63e23e2 commit b923405

2 files changed

Lines changed: 33 additions & 13 deletions

File tree

packages/devtools/src/tabs/seo-tab/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export const SeoTab = () => {
2323
class={`${styles().seoSubNavLabel} ${activeView() === 'overview' ? styles().seoSubNavLabelActive : ''}`}
2424
onClick={() => setActiveView('overview')}
2525
>
26-
SEO overview
26+
SEO Overview
2727
</button>
2828
<button
2929
type="button"
@@ -44,7 +44,7 @@ export const SeoTab = () => {
4444
class={`${styles().seoSubNavLabel} ${activeView() === 'social-previews' ? styles().seoSubNavLabelActive : ''}`}
4545
onClick={() => setActiveView('social-previews')}
4646
>
47-
Social previews
47+
Social Previews
4848
</button>
4949
<button
5050
type="button"

packages/devtools/src/tabs/seo-tab/seo-overview.tsx

Lines changed: 31 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,9 @@ function SeoSubsectionScoreRing(props: { score: number }) {
117117
)
118118
}
119119

120-
export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void }) {
120+
export function SeoOverviewSection(props: {
121+
goTo: (view: SeoDetailView) => void
122+
}) {
121123
const styles = useStyles()
122124
const [tick, setTick] = createSignal(0)
123125

@@ -135,10 +137,14 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
135137
const links = getLinksPreviewSummary()
136138

137139
const rows: Array<OverviewRow> = [
138-
{ id: 'heading-structure', title: 'Heading structure', summary: headings },
140+
{
141+
id: 'heading-structure',
142+
title: 'Heading Structure',
143+
summary: headings,
144+
},
139145
{ id: 'links-preview', title: 'Links', summary: links },
140-
{ id: 'social-previews', title: 'Social previews', summary: social },
141-
{ id: 'serp-preview', title: 'SERP preview', summary: serp },
146+
{ id: 'social-previews', title: 'Social Previews', summary: social },
147+
{ id: 'serp-preview', title: 'SERP Preview', summary: serp },
142148
{ id: 'json-ld-preview', title: 'JSON-LD', summary: jsonLd },
143149
]
144150

@@ -209,7 +215,9 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
209215
<div class={styles().serpPreviewBlock}>
210216
<div class={styles().serpPreviewLabel}>Overall health</div>
211217
<div class={styles().seoHealthHeaderRow}>
212-
<span class={styles().seoHealthLabelMuted}>{bundle().health.label}</span>
218+
<span class={styles().seoHealthLabelMuted}>
219+
{bundle().health.label}
220+
</span>
213221
<span class={healthScoreClass(bundle().health.score)}>
214222
{bundle().health.score}%
215223
</span>
@@ -224,12 +232,15 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
224232
>
225233
<div
226234
class={healthFillClass(bundle().health.score)}
227-
style={{ width: `${Math.min(100, Math.max(0, bundle().health.score))}%` }}
235+
style={{
236+
width: `${Math.min(100, Math.max(0, bundle().health.score))}%`,
237+
}}
228238
/>
229239
</div>
230240
<div class={styles().seoHealthCountsRow}>
231241
<span class={styles().seoHealthCountError}>
232-
{bundle().health.counts.error} error{bundle().health.counts.error === 1 ? '' : 's'}
242+
{bundle().health.counts.error} error
243+
{bundle().health.counts.error === 1 ? '' : 's'}
233244
</span>
234245
<span class={styles().seoHealthCountWarning}>
235246
{bundle().health.counts.warning} warning
@@ -291,7 +302,9 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
291302
<li class={styles().seoIssueRow}>
292303
<span class={issueBulletClass(issue.severity)}></span>
293304
<span class={styles().seoIssueMessage}>{issue.message}</span>
294-
<span class={issueBadgeClass(issue.severity)}>{issue.severity}</span>
305+
<span class={issueBadgeClass(issue.severity)}>
306+
{issue.severity}
307+
</span>
295308
</li>
296309
)}
297310
</For>
@@ -341,8 +354,12 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
341354
>
342355
<SeoSubsectionScoreRing score={subsectionScore} />
343356
<span class={styles().seoOverviewCheckBody}>
344-
<span class={styles().seoOverviewCheckTitle}>{row.title}</span>
345-
<span class={styles().seoOverviewCheckMeta}>{metaLine}</span>
357+
<span class={styles().seoOverviewCheckTitle}>
358+
{row.title}
359+
</span>
360+
<span class={styles().seoOverviewCheckMeta}>
361+
{metaLine}
362+
</span>
346363
</span>
347364
<span
348365
class={styles().seoOverviewCheckCounts}
@@ -378,7 +395,10 @@ export function SeoOverviewSection(props: { goTo: (view: SeoDetailView) => void
378395
{c.info}
379396
</span>
380397
</span>
381-
<span class={styles().seoOverviewCheckChevron} aria-hidden="true">
398+
<span
399+
class={styles().seoOverviewCheckChevron}
400+
aria-hidden="true"
401+
>
382402
383403
</span>
384404
</button>

0 commit comments

Comments
 (0)