[Codex] fix(security): restrict config export/import to admins#503
Open
Micsi wants to merge 1 commit into
Open
[Codex] fix(security): restrict config export/import to admins#503Micsi wants to merge 1 commit into
Micsi wants to merge 1 commit into
Conversation
Owner
|
@Micsi |
Collaborator
Author
|
Warum @abeggled? . Ich habe eine Mietwohnung und möchte daher den Zugriff konsequent auf allen Ebenen beschränken können. Warum sollte ein User Daten oder Configs exportieren können? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
export/importendpoints allowed any authenticated user or API key to export secret-bearinglogic_graphs.flow_dataand import enabled executable logic.Description
get_current_usertoget_admin_userforGET /api/v1/config/exportandPOST /api/v1/config/importinobs/api/v1/config.pyso only admins can export or restore logic graphs.Testing
pytest -q tests/integration/test_auth.py, but the run failed due to a missing test dependency (pytest_asyncio) in the local environment, so no tests passed here.Codex Task