[Codex] fix(auth): require authentication for datapoint value reads and websocket connections#553
Open
Micsi wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
Sync-Update aus dem Fork-PR: Micsi#59 In diesem Update wurden folgende Punkte auf den Upstream-PR synchronisiert:
Enthaltene neue Commits in diesem Stand:
Aktueller PR-Stand:
|
Collaborator
Author
|
Nachtrag zum letzten Sync aus dem Fork-PR Micsi#59: Auf Basis eines neuen Reviews wurde noch ein weiterer Security-Fix nachgezogen:
Zusätzlicher Commit:
Der Stand ist auf Fork-PR #59 und Upstream-PR #553 identisch (gleicher Head-SHA). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
get_current_userinobs/api/v1/datapoints.pyforGET /{dp_id}/value.obs/api/v1/websocket.pyby rejecting connections without a token with4001 Authentication requiredand continuing to reject invalid tokens with4001 Invalid token.obs/api/v1/datapoints.pyandobs/api/v1/websocket.pyand are intentionally minimal to restore prior access controls.Testing
pytest -q obs/api/v1/test_datapoints.py obs/api/v1/test_websocket.pywhich failed because those targeted test files are not present in this repo layout (no tests collected).pytest -qwhich aborted collection due to a missing test dependency (ModuleNotFoundError: No module named 'pytest_asyncio'), so full test suite execution could not be completed in this environment.Codex Task