[Codex] fix(security): sanitize SVG uploads and restrict icon import to admins#555
Open
Micsi wants to merge 4 commits into
Open
[Codex] fix(security): sanitize SVG uploads and restrict icon import to admins#555Micsi wants to merge 4 commits into
Micsi wants to merge 4 commits into
Conversation
Collaborator
Author
|
🔄 Promotion-Update aus dem Fork Diese Upstream-PR wurde in dieser Session mit dem aktuellen Stand aus Micsi#48 synchronisiert. Synchronisierte Änderungen
Review-Setup Enthaltener Commit-Stand (gegen
Lokale Verifikation inkl. Pre-Push-Gates war grün ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v-html.Description
_sanitize_svg(content: bytes) -> byteshelper that parses SVG XML and removes risky constructs and attributes (stripsscript/foreignObject/iframe/object/embed, removeson*event attributes andjavascript:hrefs) usingxml.etree.ElementTreeand raisesHTTPException(422)for invalid XML._sanitize_svg(...)beforewrite_bytes.get_current_usertoget_admin_useronPOST /api/v1/icons/importto prevent low-privileged users from planting payloads.tests/unit/test_icons.pyfor the sanitizer behavior (event-handler stripping, removal of script/foreignObject, and rejection of invalid XML).Testing
pytest -q tests/unit/test_icons.pyand all unit tests passed (27 passed, 1 warning).tests/integration/test_icons.py) but the environment lackedpytest_asyncio, so the integration tests were not executed here (local CI should run the full integration suite).Codex Task