[Codex] fix(frontend): sanitize inline SVG icon content before v-html render#557
Open
Micsi wants to merge 3 commits into
Open
[Codex] fix(frontend): sanitize inline SVG icon content before v-html render#557Micsi wants to merge 3 commits into
Micsi wants to merge 3 commits into
Conversation
Collaborator
Author
|
🔄 Promotion-Update aus dem Fork Diese Upstream-PR wurde in dieser Session mit dem Stand aus Micsi#44 synchronisiert. Vorgenommene Änderungen Aktueller Commit-Stand aus dem Fork
Bitte den aktualisierten Stand für das Review verwenden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Tracking
Motivation
v-htmlwithout sanitization, which creates a stored XSS vector when authenticated users upload crafted SVGs and nodes reference them viasvg:{name}.VisuIconwhile preserving existing UI behavior.Description
normalizeSvginfrontend/src/composables/useIcons.tsto parse SVG withDOMParserand return an empty string for non-<svg>roots.script,foreignObject,iframe,object,embed,audio,video) before returning content.on) and removed dangerous URL-bearing attributes (href,xlink:href,src) when they usejavascript:,data:, or externalhttp(s)schemes, and preserved the prior rootwidth/heightstripping logic so CSS sizing remains unchanged.VisuIcon,VisuTree,NodeOverview,Breadcrumb) untouched and perform sanitization centrally in the icons composable.Testing
cd frontend && npm run typecheckand the command completed without errors.Codex Task