[Codex] security: reject active/scriptable SVGs on icon import (prevent stored XSS)#558
Open
Micsi wants to merge 2 commits into
Open
[Codex] security: reject active/scriptable SVGs on icon import (prevent stored XSS)#558Micsi wants to merge 2 commits into
Micsi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
<svg>check, and stored SVGs were later returned verbatim and rendered withv-html, enabling stored XSS.Description
_sanitize_svginobs/api/v1/icons.pythat rejects SVGs containing active/scriptable constructs such as<script>,<foreignObject>, inlineon*=handlers, andjavascript:/data:links./api/v1/icons/import) for both single-file and ZIP-member flows so only safe SVG bytes are written.obs/api/v1/config.pyso base64-decoded icons from config imports are validated before being stored.tests/unit/test_icons.pythat assert acceptance of minimal SVG and rejection of malicious patterns.Testing
pytest -q tests/unit/test_icons.pyand all unit tests passed (28 passed).pytest_asynciodependency (so integration tests were not executed here).Codex Task