fix: topic-complete header + welcome copy (CodeRabbit follow-up to #31)#32
Conversation
Addresses the real findings from CodeRabbit's review of #31: - Major: topic-only completion called OutputPanel.show_final(), which hardcodes the 'All exercises complete' header — misleading when only the current topic is done. Added show_topic_complete() (shared body factored into _show_complete) with a 'Topic complete' header, and used it in both the on-mount already-complete path and the post-pass else branch. The whole-curriculum celebration still uses show_final(). - Minor: welcome copy said 'Save -- ... as you type', which is contradictory and wrong for v0.4.0 (the built-in editor reruns checks as you type, no manual save). Copy and its test updated. - Minor: added 'from __future__ import annotations' to test_welcome_pilot.py per repo convention. Skipped the RUF012 nit on WelcomeScreen.BINDINGS: a plain list matches every other screen in the codebase (Textual idiom) and the rule is not enforced. Tests: 2 new output-panel header tests; full suite 147 passed on 3.9 and 3.13.
|
Warning Review limit reached
More reviews will be available in 37 minutes and 56 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #31, addressing CodeRabbit's review findings that were merged before being read (a filter bug on my side missed the inline comments).
Fixed
OutputPanel.show_final(), which hardcodes the "All exercises complete" header. Addedshow_topic_complete()(shared body factored into_show_complete) with a "Topic complete" header, used in both the on-mount already-complete path and the post-passelsebranch. The whole-curriculum celebration still usesshow_final().from __future__ import annotationsadded totest_welcome_pilot.pyper repo convention.Skipped (with reason)
WelcomeScreen.BINDINGS— a plainBINDINGS = [...]list matches every other screen in the codebase (Textual idiom); the rule isn't enforced, and changing only this one would be inconsistent.Tests
2 new output-panel header tests (topic-complete uses the topic header, not the global one;
show_finalkeeps the global header). Full suite 147 passed on Python 3.9 and 3.13.