Skip to content

fix: topic-complete header + welcome copy (CodeRabbit follow-up to #31)#32

Merged
abhiksark merged 1 commit into
mainfrom
fix/topic-complete-header-and-welcome-copy
Jun 21, 2026
Merged

fix: topic-complete header + welcome copy (CodeRabbit follow-up to #31)#32
abhiksark merged 1 commit into
mainfrom
fix/topic-complete-header-and-welcome-copy

Conversation

@abhiksark

Copy link
Copy Markdown
Owner

Follow-up to #31, addressing CodeRabbit's review findings that were merged before being read (a filter bug on my side missed the inline comments).

Fixed

  • 🟠 Major — misleading completion header. Topic-only completion called OutputPanel.show_final(), which hardcodes the "All exercises complete" header. Added show_topic_complete() (shared body factored into _show_complete) with a "Topic complete" header, used in both the on-mount already-complete path and the post-pass else branch. The whole-curriculum celebration still uses show_final().
  • 🟡 Minor — welcome copy. "Save … as you type" was contradictory and wrong for v0.4.0 (built-in editor reruns checks as you type, no manual save). Copy + test updated.
  • 🟡 Minor — from __future__ import annotations added to test_welcome_pilot.py per repo convention.

Skipped (with reason)

  • RUF012 on WelcomeScreen.BINDINGS — a plain BINDINGS = [...] list matches every other screen in the codebase (Textual idiom); the rule isn't enforced, and changing only this one would be inconsistent.

Tests

2 new output-panel header tests (topic-complete uses the topic header, not the global one; show_final keeps the global header). Full suite 147 passed on Python 3.9 and 3.13.

Addresses the real findings from CodeRabbit's review of #31:

- Major: topic-only completion called OutputPanel.show_final(), which
  hardcodes the 'All exercises complete' header — misleading when only the
  current topic is done. Added show_topic_complete() (shared body factored
  into _show_complete) with a 'Topic complete' header, and used it in both
  the on-mount already-complete path and the post-pass else branch. The
  whole-curriculum celebration still uses show_final().
- Minor: welcome copy said 'Save -- ... as you type', which is contradictory
  and wrong for v0.4.0 (the built-in editor reruns checks as you type, no
  manual save). Copy and its test updated.
- Minor: added 'from __future__ import annotations' to test_welcome_pilot.py
  per repo convention.

Skipped the RUF012 nit on WelcomeScreen.BINDINGS: a plain list matches every
other screen in the codebase (Textual idiom) and the rule is not enforced.

Tests: 2 new output-panel header tests; full suite 147 passed on 3.9 and 3.13.
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@abhiksark, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 37 minutes and 56 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f28ccf93-7f12-4903-977a-79b3928e6f58

📥 Commits

Reviewing files that changed from the base of the PR and between 29e29bb and 2ce93a0.

📒 Files selected for processing (6)
  • pythonlings/screens/track.py
  • pythonlings/screens/welcome.py
  • pythonlings/widgets/output_panel.py
  • tests/tui/test_output_panel.py
  • tests/tui/test_welcome_pilot.py
  • tests/unit/test_welcome.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/topic-complete-header-and-welcome-copy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abhiksark abhiksark merged commit 28aaf5b into main Jun 21, 2026
4 checks passed
@abhiksark abhiksark deleted the fix/topic-complete-header-and-welcome-copy branch June 21, 2026 14:17
@abhiksark abhiksark mentioned this pull request Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant