Skip to content

Commit a3df15c

Browse files
Itolstoganovasl
authored andcommitted
Add virtual destructors
1 parent a0184e4 commit a3df15c

5 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/common/auxiliary_graphs/contracted_graph/contracted_graph_helper.hpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,8 @@ class ContractedGraphFactoryHelper {
1515
public:
1616
typedef debruijn_graph::VertexId VertexId;
1717
typedef debruijn_graph::Graph Graph;
18-
19-
explicit ContractedGraphFactoryHelper(const debruijn_graph::Graph &g) : g_(g) {}
20-
18+
2119
std::shared_ptr<ContractedGraph> ExtractContractedSubgraph(const ContractedGraph &other,
2220
const std::unordered_set<VertexId> &vertices) const;
23-
24-
private:
25-
const Graph& g_;
2621
};
2722
}

src/common/auxiliary_graphs/scaffold_graph/scaffold_vertex_index.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ class ScaffoldVertexIndexInfoExtractor {
6868
public:
6969
typedef typename scaffold_graph::ScaffoldVertex ScaffoldVertex;
7070

71+
virtual ~ScaffoldVertexIndexInfoExtractor() = default;
72+
7173
public:
7274
virtual size_t GetHeadSize(const ScaffoldVertex &vertex) const = 0;
7375
virtual size_t GetTailSize(const ScaffoldVertex &vertex) const = 0;

src/common/auxiliary_graphs/scaffold_graph/scaffold_vertex_index_builder.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@ namespace barcode_index {
1515
template <class EdgeEntryT>
1616
class AbstractScaffoldVertexEntryExtractor {
1717
public:
18+
virtual ~AbstractScaffoldVertexEntryExtractor() = default;
1819
virtual EdgeEntryT ExtractEntry(const scaffold_graph::ScaffoldVertex &vertex) const = 0;
1920
};
2021

2122
class TailThresholdGetter {
2223
public:
24+
virtual ~TailThresholdGetter() = default;
2325
virtual size_t GetTailThreshold(const scaffold_graph::ScaffoldVertex &vertex) const = 0;
2426
};
2527

@@ -213,7 +215,6 @@ namespace barcode_index {
213215
const ContainerT& vertex_container, size_t count_threshold,
214216
size_t max_threads) {
215217
const size_t length_threshold = 1000;
216-
const size_t linkage_distance = 10;
217218
const double EDGE_LENGTH_FRACTION = 0.5;
218219
auto threshold_getter = std::make_shared<barcode_index::FractionTailThresholdGetter>(g, EDGE_LENGTH_FRACTION);
219220
auto split_scaffold_vertex_index = ConstructScaffoldVertexIndex(g, extractor,

src/common/barcode_index/barcode_info_extractor.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ namespace barcode_index {
3232
BarcodeIndexInfoExtractor(const BarcodeIndexT &index, const Graph &g) :
3333
index_(index), g_(g) {}
3434

35+
virtual ~BarcodeIndexInfoExtractor() = default;
36+
3537
/**
3638
*
3739
* @param edge

src/common/modules/path_extend/scaffolder2015/scaffold_graph_constructor.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class ScaffoldGraphConstructor {
3131
public:
3232
typedef scaffold_graph::ScaffoldGraph ScaffoldGraph;
3333

34+
virtual ~ScaffoldGraphConstructor() = default;
3435
virtual std::shared_ptr<ScaffoldGraph> Construct() = 0;
3536
};
3637

0 commit comments

Comments
 (0)