Skip to content

Introduce frugal mode#1571

Merged
asl merged 2 commits into
mainfrom
frugal
May 26, 2026
Merged

Introduce frugal mode#1571
asl merged 2 commits into
mainfrom
frugal

Conversation

@asl
Copy link
Copy Markdown
Member

@asl asl commented Apr 28, 2026

No description provided.

@asl asl requested a review from andrewprzh April 28, 2026 20:04
@asl
Copy link
Copy Markdown
Member Author

asl commented Apr 28, 2026

For now "usual" CI run to ensure that nothing will change / break

Copy link
Copy Markdown
Collaborator

@andrewprzh andrewprzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  • Word "frugal" is cool but not so common, any synonyms? (just for the sake of non-native speakers)

  • I checked calls of EnsureBasicMapping across the project, seems to be correct, but just in case to double check:

./projects/online_vis/base_commands.hpp: EnsureBasicMapping(curr_env->graph_pack()); ./projects/hpcspades/mismatch_correction_mpi.hpp: EnsureBasicMapping(gp); ./projects/spades/restricted_edges_filling.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/spades/pair_info_count.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/spades/series_analysis.cpp:// gp.EnsureBasicMapping(); ./projects/spades/mismatch_correction.cpp: EnsureBasicMapping(gp); ./projects/spades/hybrid_aligning.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/cds_subgraphs/stats.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/cds_subgraphs.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/unitig_coverage.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/mag_improve.cpp: EnsureBasicMapping(gp); ./common/pipeline/graph_pack_helpers.cpp:void EnsureBasicMapping(GraphPack& gp, bool check_mapper) { ./common/pipeline/graph_pack_helpers.cpp: EnsureBasicMapping(gp); ./common/pipeline/graph_pack_helpers.h:void EnsureBasicMapping(graph_pack::GraphPack& gp, ./common/stages/ss_edge_split.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./test/debruijn/test_utils.cpp: EnsureBasicMapping(gp); ./test/examples/thread_sequences.cpp: EnsureBasicMapping(gp);

@asl
Copy link
Copy Markdown
Member Author

asl commented May 6, 2026

  • I checked calls of EnsureBasicMapping across the project, seems to be correct, but just in case to double check:

Yeah, I checked all of them. Essentially mismatch corrector is entirely disabled as it uses kmer mapper in non-trivial way. Everything else just does sequence mapping and therefore can operate without kmer mapper.

@asl asl merged commit 1e3a239 into main May 26, 2026
142 of 164 checks passed
@asl asl deleted the frugal branch May 26, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants