Skip to content

Commit 847b246

Browse files
rp-dhslove
authored andcommitted
linstor: do not use the same static ApiClient for all calls (apache#9326)
The client.setBasePath() would overwrite the Linstor controller IP/host for all current client users. This is basically a race condition that triggered as soon as you had configured 2 different primary storages with different Linstor controllers.
1 parent 99e4e09 commit 847b246

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

  • plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util

plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import com.linbit.linstor.api.ApiClient;
2020
import com.linbit.linstor.api.ApiException;
21-
import com.linbit.linstor.api.Configuration;
2221
import com.linbit.linstor.api.DevelopersApi;
2322
import com.linbit.linstor.api.model.ApiCallRc;
2423
import com.linbit.linstor.api.model.ApiCallRcList;
@@ -53,7 +52,7 @@ public class LinstorUtil {
5352
public static final String CLUSTER_DEFAULT_MAX_IOPS = "clusterDefaultMaxIops";
5453

5554
public static DevelopersApi getLinstorAPI(String linstorUrl) {
56-
ApiClient client = Configuration.getDefaultApiClient();
55+
ApiClient client = new ApiClient();
5756
client.setBasePath(linstorUrl);
5857
return new DevelopersApi(client);
5958
}

0 commit comments

Comments
 (0)