-
Notifications
You must be signed in to change notification settings - Fork 61
fix: enable multi-user chat with unique client IDs and message styling #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
994bd35
fix: enable multi-user chat with unique client IDs and sent/received …
rainbowFi 3fb3643
fix: update useChatClient for Chat SDK v1.x API
rainbowFi fa527ff
fix: pass clientId from browser to auth endpoint
rainbowFi a587cb6
docs: restore comment explaining revalidate = 0
rainbowFi 165b702
fix: use JWT for token authentication
rainbowFi a87fbdd
fix: scope JWT capability to chat-demo room channels
rainbowFi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,26 @@ | ||
| import Ably from 'ably'; | ||
| import jwt from 'jsonwebtoken'; | ||
|
|
||
| // ensure Vercel doesn't cache the result of this route, | ||
| // as otherwise the token request data will eventually become outdated | ||
| // and we won't be able to authenticate on client side | ||
| export const revalidate = 0; | ||
|
|
||
| export async function GET(request) { | ||
| const client = new Ably.Rest(process.env.ABLY_API_KEY); | ||
| const tokenRequestData = await client.auth.createTokenRequest({ | ||
| clientId: 'ably-nextjs-demo', | ||
| const clientId = request.nextUrl.searchParams.get('clientId') || 'NO_CLIENT_ID_PROVIDED'; | ||
| const [keyName, keySecret] = process.env.ABLY_API_KEY.split(':'); | ||
|
|
||
| const now = Math.floor(Date.now() / 1000); | ||
| const claims = { | ||
| 'x-ably-capability': JSON.stringify({ 'chat-demo:*': ['*'] }), | ||
| 'x-ably-clientId': clientId, | ||
| iat: now, | ||
| exp: now + 3600, | ||
| }; | ||
|
|
||
| const token = jwt.sign(claims, keySecret, { algorithm: 'HS256', keyid: keyName }); | ||
|
|
||
| return new Response(token, { | ||
| status: 200, | ||
| headers: { 'Content-Type': 'application/jwt' }, | ||
| }); | ||
| console.log(`Request: ${JSON.stringify(tokenRequestData)}`); | ||
| return Response.json(tokenRequestData); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description suggests clientId's are generated with
crypto.randomUUID(), can we update the PR description please :)