Addressed copilot feedback

Author: sacOO7

src/utils/prompt-confirmation.ts

@@ -6,7 +6,8 @@ import * as readline from "node:readline";
  * Accepts both "y" and "yes" as affirmative responses (case-insensitive).
  *
  * @param message - The confirmation message to display to the user
- * @param defaultValue - The value returned when the user presses Enter without typing (default: false)
+ * @param defaultValue - The value returned when the user presses Enter without typing (default: false).
+ *   Note: SIGINT and close always resolve to false regardless of defaultValue, since cancellation should never confirm.
  * @returns Promise<boolean> - true if user confirms (y/yes), false otherwise
  */
 export function promptForConfirmation(
@@ -44,11 +45,11 @@ export function promptForConfirmation(
     };
 
     rl.on("SIGINT", () => {
-      finish(defaultValue);
+      finish(false);
     });
 
     rl.on("close", () => {
-      finish(defaultValue);
+      finish(false);
     });
 
     rl.question(promptMessage, (answer) => {

test/unit/utils/prompt-confirmation.test.ts

@@ -1,6 +1,7 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
 
 let mockQuestion: (query: string, callback: (answer: string) => void) => void;
+let mockOnHandlers: Record<string, (() => void)[]>;
 
 vi.mock("node:readline", () => ({
   createInterface: () => ({
@@ -9,7 +10,12 @@ vi.mock("node:readline", () => ({
     question: (query: string, callback: (answer: string) => void) => {
       mockQuestion(query, callback);
     },
-    on: vi.fn(),
+    on: (event: string, handler: () => void) => {
+      if (!mockOnHandlers[event]) {
+        mockOnHandlers[event] = [];
+      }
+      mockOnHandlers[event].push(handler);
+    },
   }),
 }));
 
@@ -18,6 +24,7 @@ import { promptForConfirmation } from "../../../src/utils/prompt-confirmation.js
 describe("promptForConfirmation", () => {
   beforeEach(() => {
     vi.restoreAllMocks();
+    mockOnHandlers = {};
   });
 
   it.each(["y", "yes", "Y", "YES", " yes "])(
@@ -103,4 +110,46 @@ describe("promptForConfirmation", () => {
       expect(capturedQuery).toBe("Continue? [Y/n]");
     });
   });
+
+  describe("SIGINT and close handling", () => {
+    it("returns false on SIGINT even when defaultValue is true", async () => {
+      mockQuestion = () => {
+        for (const handler of mockOnHandlers["SIGINT"] ?? []) {
+          handler();
+        }
+      };
+      const result = await promptForConfirmation("Did you mean X?", true);
+      expect(result).toBe(false);
+    });
+
+    it("returns false on close even when defaultValue is true", async () => {
+      mockQuestion = () => {
+        for (const handler of mockOnHandlers["close"] ?? []) {
+          handler();
+        }
+      };
+      const result = await promptForConfirmation("Did you mean X?", true);
+      expect(result).toBe(false);
+    });
+
+    it("returns false on SIGINT with default defaultValue", async () => {
+      mockQuestion = () => {
+        for (const handler of mockOnHandlers["SIGINT"] ?? []) {
+          handler();
+        }
+      };
+      const result = await promptForConfirmation("Delete this?");
+      expect(result).toBe(false);
+    });
+
+    it("returns false on close with default defaultValue", async () => {
+      mockQuestion = () => {
+        for (const handler of mockOnHandlers["close"] ?? []) {
+          handler();
+        }
+      };
+      const result = await promptForConfirmation("Delete this?");
+      expect(result).toBe(false);
+    });
+  });
 });