Fix JSON mode bugs: guard interactive prompts, route warnings to stderr, enforce --force

- Respect --json with --token-only in auth token commands
- Auto-remove invalid/revoked keys in JSON mode instead of hanging on prompts
- Enforce --force flag for push publish commands in JSON mode
- Route formatLimitWarning output to stderr (19 commands)
- Migrate this.warn() to this.logWarning() for structured JSON warnings
- Fix premature logListening emission before subscription is ready
- Fix shouldOutputJson({}) dead code in bench commands

Author: umair-ably

README.md

@@ -2970,7 +2970,7 @@ ARGUMENTS
            key. Items with "channels" are routed via channel batch publish with the payload wrapped in extras.push
 
 FLAGS
-  -f, --force        Skip confirmation prompt when publishing to channels (confirmation is also skipped in --json mode)
+  -f, --force        Skip confirmation prompt (required with --json)
   -v, --verbose      Output verbose logs
       --json         Output in JSON format
       --pretty-json  Output in colorized JSON format
@@ -3585,8 +3585,7 @@ USAGE
     [--web <value>] [-f]
 
 FLAGS
-  -f, --force                 Skip confirmation prompt when publishing to a channel (confirmation is also skipped in
-                              --json mode)
+  -f, --force                 Skip confirmation prompt (required with --json)
   -v, --verbose               Output verbose logs
       --apns=<value>          APNs-specific override as JSON
       --badge=<value>         Notification badge count

src/base-command.ts

@@ -1008,10 +1008,9 @@ export abstract class AblyBaseCommand extends InteractiveBaseCommand {
       // When using token auth, we don't set the clientId as it may conflict
       // with any clientId embedded in the token
       if (flags["client-id"] && !this.shouldSuppressOutput(flags)) {
-        this.logToStderr(
-          chalk.yellow(
-            "Warning: clientId is ignored when using token authentication as the clientId is embedded in the token",
-          ),
+        this.logWarning(
+          "clientId is ignored when using token authentication as the clientId is embedded in the token.",
+          flags,
         );
       }
     } else if (flags["api-key"]) {
@@ -1337,15 +1336,22 @@ export abstract class AblyBaseCommand extends InteractiveBaseCommand {
     const appId = flags.app || this.configManager.getCurrentAppId();
 
     if (appId) {
-      this.log("The configured API key appears to be invalid or revoked.");
+      if (this.shouldOutputJson(flags)) {
+        // In JSON mode, auto-remove the invalid key — it can't be used anyway
+        this.configManager.removeApiKey(appId);
+      } else {
+        this.logToStderr(
+          "The configured API key appears to be invalid or revoked.",
+        );
 
-      const shouldRemove = await this.interactiveHelper.confirm(
-        "Would you like to remove this invalid key from your configuration?",
-      );
+        const shouldRemove = await this.interactiveHelper.confirm(
+          "Would you like to remove this invalid key from your configuration?",
+        );
 
-      if (shouldRemove) {
-        this.configManager.removeApiKey(appId);
-        this.log("Invalid key removed from configuration.");
+        if (shouldRemove) {
+          this.configManager.removeApiKey(appId);
+          this.logToStderr("Invalid key removed from configuration.");
+        }
       }
     }
   }

src/commands/accounts/current.ts

@@ -132,8 +132,9 @@ export default class AccountsCurrent extends ControlBaseCommand {
           flags,
         );
       } else {
-        this.warn(
+        this.logWarning(
           "Unable to verify account information. Your access token may have expired.",
+          flags,
         );
         this.log(
           chalk.yellow(
@@ -232,7 +233,7 @@ export default class AccountsCurrent extends ControlBaseCommand {
           flags,
         );
       } else {
-        this.warn(errorMessage(error));
+        this.logWarning(errorMessage(error), flags);
         this.log(
           `${formatLabel("Info")} Your access token may have expired or is invalid.`,
         );

src/commands/accounts/switch.ts

@@ -167,7 +167,7 @@ export default class AccountsSwitch extends ControlBaseCommand {
           flags,
         );
       } else {
-        this.warn(warningMessage);
+        this.logWarning(warningMessage, flags);
       }
     }
   }

src/commands/apps/current.ts

@@ -205,8 +205,9 @@ export default class AppsCurrent extends ControlBaseCommand {
           `${formatLabel("App")} ${chalk.green.bold("Unknown")} ${chalk.gray(`(${appId})`)}`,
         );
         this.log(`${formatLabel("API Key")} ${chalk.yellow.bold(keyId)}`);
-        this.warn(
+        this.logWarning(
           `Could not fetch additional app details: ${errorMessage(error)}`,
+          flags,
         );
         this.log(
           `${formatLabel("Mode")} ${chalk.magenta.bold("Web CLI")} ${chalk.dim("(using environment variables)")}`,

src/commands/apps/list.ts

@@ -91,7 +91,7 @@ export default class AppsList extends ControlBaseCommand {
 
         if (hasMore) {
           const warning = formatLimitWarning(apps.length, flags.limit, "apps");
-          if (warning) this.log(warning);
+          if (warning) this.logToStderr(warning);
         }
       },
       "Error listing apps",

src/commands/apps/rules/list.ts

@@ -118,7 +118,7 @@ export default class RulesListCommand extends ControlBaseCommand {
             flags.limit,
             "rules",
           );
-          if (warning) this.log(warning);
+          if (warning) this.logToStderr(warning);
         }
       }
     } catch (error) {

src/commands/auth/issue-ably-token.ts

@@ -112,7 +112,11 @@ export default class IssueAblyTokenCommand extends AblyBaseCommand {
 
       // If token-only flag is set, output just the token string
       if (flags["token-only"]) {
-        this.log(tokenDetails.token);
+        if (this.shouldOutputJson(flags)) {
+          this.logJsonResult({ token: { value: tokenDetails.token } }, flags);
+        } else {
+          this.log(tokenDetails.token);
+        }
         return;
       }
 

src/commands/auth/issue-jwt-token.ts

@@ -128,7 +128,11 @@ export default class IssueJwtTokenCommand extends AblyBaseCommand {
 
       // If token-only flag is set, output just the token string
       if (flags["token-only"]) {
-        this.log(token);
+        if (this.shouldOutputJson(flags)) {
+          this.logJsonResult({ token: { value: token } }, flags);
+        } else {
+          this.log(token);
+        }
         return;
       }
 

src/commands/auth/keys/list.ts

@@ -114,7 +114,7 @@ export default class KeysListCommand extends ControlBaseCommand {
 
         if (hasMore) {
           const warning = formatLimitWarning(keys.length, flags.limit, "keys");
-          if (warning) this.log(warning);
+          if (warning) this.logToStderr(warning);
         }
       }
     } catch (error) {