Add error code 40025 for APIs that are no longer supported#340
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AndyTWF
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
40025: "API no longer supported"toprotocol/errors.json, placed alongside the existing version/compatibility codes (40021, 40023, 40024).Why
Requested in ably-js#2226 review feedback. That PR re-introduces the deleted v1 callback-style APIs in a deprecated form, throwing synchronously to nudge LLMs/users toward the v2 promise-based APIs. It currently raises ErrorInfo with code
40000("bad request"), which is generic and overused.A dedicated code:
40000.The wording is intentionally generic ("API no longer supported") so future deprecations can reuse it.
Test plan
40025.