[ECO-5338] Fixed liveobject test dependency

1. Fixed liveobject channel options while initializing test channel
2. Fixed test utils as per review comments
3. Fixed adapter NotNull annotation for send method

Author: sacOO7

lib/src/main/java/io/ably/lib/objects/Adapter.java

@@ -25,7 +25,7 @@ public void setChannelSerial(@NotNull String channelName, @NotNull String channe
     }
 
     @Override
-    public void send(ProtocolMessage msg, CompletionListener listener) throws AblyException {
+    public void send(@NotNull ProtocolMessage msg, @NotNull CompletionListener listener) throws AblyException {
         // Always queue LiveObjects messages to ensure reliable state synchronization and proper acknowledgment
         ably.connection.connectionManager.send(msg, true, listener);
     }

lib/src/main/java/io/ably/lib/objects/LiveObjectsAdapter.java

@@ -15,7 +15,7 @@ public interface LiveObjectsAdapter {
      * @param listener a listener to be notified of the success or failure of the send operation.
      * @throws AblyException if an error occurs during the send operation.
      */
-    void send(ProtocolMessage msg, CompletionListener listener) throws AblyException;
+    void send(@NotNull ProtocolMessage msg, @NotNull CompletionListener listener) throws AblyException;
 
     /**
      * Sets the channel serial for a specific channel.

live-objects/build.gradle.kts

@@ -25,10 +25,6 @@ tasks.withType<Test>().configureEach {
     jvmArgs("--add-opens", "java.base/java.lang=ALL-UNNAMED")
     beforeTest(closureOf<TestDescriptor> { logger.lifecycle("-> $this") })
     outputs.upToDateWhen { false }
-    // Skip tests for the "release" build type so we don't run tests twice
-    if (name.lowercase().contains("release")) {
-        enabled = false
-    }
 }
 
 tasks.register<Test>("runLiveObjectUnitTests") {
@@ -40,7 +36,8 @@ tasks.register<Test>("runLiveObjectUnitTests") {
 tasks.register<Test>("runLiveObjectIntegrationTests") {
     filter {
         includeTestsMatching("io.ably.lib.objects.integration.*")
-        exclude("**/IntegrationTest.class") // Exclude the base integration test class
+        // Exclude the base integration test class
+        excludeTestsMatching("io.ably.lib.objects.integration.setup.IntegrationTest")
     }
 }
 

live-objects/src/test/kotlin/io/ably/lib/objects/integration/setup/IntegrationTest.kt

@@ -2,6 +2,8 @@ package io.ably.lib.objects.integration.setup
 
 import io.ably.lib.realtime.AblyRealtime
 import io.ably.lib.realtime.Channel
+import io.ably.lib.types.ChannelMode
+import io.ably.lib.types.ChannelOptions
 import kotlinx.coroutines.runBlocking
 import org.junit.After
 import org.junit.AfterClass
@@ -40,7 +42,10 @@ abstract class IntegrationTest {
         useBinaryProtocol = testParams == "msgpack_protocol"
       }. apply { ensureConnected() }
     }
-    return client.channels.get(channelName).apply {
+    val channelOpts = ChannelOptions().apply {
+      modes = arrayOf(ChannelMode.object_publish, ChannelMode.object_subscribe)
+    }
+    return client.channels.get(channelName, channelOpts).apply {
       attach()
       ensureAttached()
     }

live-objects/src/test/kotlin/io/ably/lib/objects/integration/setup/Sandbox.kt

@@ -11,16 +11,13 @@ import io.ktor.client.network.sockets.ConnectTimeoutException
 import io.ktor.client.network.sockets.SocketTimeoutException
 import io.ktor.client.plugins.HttpRequestRetry
 import io.ktor.client.plugins.HttpRequestTimeoutException
-import io.ktor.client.request.post
-import io.ktor.client.request.setBody
+import io.ktor.client.request.*
 import io.ktor.client.statement.HttpResponse
 import io.ktor.client.statement.bodyAsText
 import io.ktor.http.ContentType
 import io.ktor.http.contentType
 import io.ktor.http.isSuccess
 import kotlinx.coroutines.CompletableDeferred
-import java.nio.file.Files
-import java.nio.file.Paths
 
 private val client = HttpClient(CIO) {
   install(HttpRequestRetry) {
@@ -39,11 +36,12 @@ private val client = HttpClient(CIO) {
 
 class Sandbox private constructor(val appId: String, val apiKey: String) {
   companion object {
-    private fun loadAppCreationJson(): JsonElement {
-      val filePath = Paths.get("../lib/src/test/resources/ably-common/test-resources/test-app-setup.json")
-      val fileContent = Files.readString(filePath)
-      return JsonParser.parseString(fileContent).asJsonObject.get("post_apps")
-    }
+    private suspend fun loadAppCreationJson(): JsonElement =
+      JsonParser.parseString(
+        client.get("https://raw.githubusercontent.com/ably/ably-common/refs/heads/main/test-resources/test-app-setup.json") {
+          contentType(ContentType.Application.Json)
+        }.bodyAsText(),
+      ).asJsonObject.get("post_apps")
 
     internal suspend fun createInstance(): Sandbox {
       val response: HttpResponse = client.post("https://sandbox.realtime.ably-nonprod.net/apps") {

live-objects/src/test/kotlin/io/ably/lib/objects/unit/TestHelpers.kt

@@ -3,29 +3,35 @@ package io.ably.lib.objects.unit
 import io.ably.lib.realtime.AblyRealtime
 import io.ably.lib.realtime.Channel
 import io.ably.lib.realtime.ChannelState
+import io.ably.lib.types.ChannelMode
+import io.ably.lib.types.ChannelOptions
 import io.ably.lib.types.ClientOptions
 import io.mockk.every
 import io.mockk.mockk
 import io.mockk.spyk
 
-internal fun getMockRealtimeChannel(channelName: String, clientId: String = "client1"): Channel {
-  val client = AblyRealtime(ClientOptions().apply {
-    autoConnect = false
-    key = "keyName:Value"
-    this.clientId = clientId
-  })
-  val channel = client.channels.get(channelName)
-  return spyk(channel) {
-    every { attach() } answers {
+internal fun getMockRealtimeChannel(
+  channelName: String,
+  clientId: String = "client1",
+  channelModes: Array<ChannelMode> = arrayOf(ChannelMode.object_publish, ChannelMode.object_subscribe)): Channel {
+    val client = AblyRealtime(ClientOptions().apply {
+      autoConnect = false
+      key = "keyName:Value"
+      this.clientId = clientId
+    })
+    val channelOpts = ChannelOptions().apply { modes = channelModes }
+    val channel = client.channels.get(channelName, channelOpts)
+    return spyk(channel) {
+      every { attach() } answers {
+        state = ChannelState.attached
+      }
+      every { detach() } answers {
+        state = ChannelState.detached
+      }
+      every { subscribe(any<String>(), any()) } returns mockk(relaxUnitFun = true)
+      every { subscribe(any<Array<String>>(), any()) } returns mockk(relaxUnitFun = true)
+      every { subscribe(any()) } returns mockk(relaxUnitFun = true)
+    }.apply {
       state = ChannelState.attached
     }
-    every { detach() } answers {
-      state = ChannelState.detached
-    }
-    every { subscribe(any<String>(), any()) } returns mockk(relaxUnitFun = true)
-    every { subscribe(any<Array<String>>(), any()) } returns mockk(relaxUnitFun = true)
-    every { subscribe(any()) } returns mockk(relaxUnitFun = true)
-  }.apply {
-    state = ChannelState.attached
-  }
 }