[ECO-5076] Updated ObjectsState enum to use PascalCase instead of all uppercase

Author: sacOO7

live-objects/src/main/kotlin/io/ably/lib/objects/DefaultLiveObjects.kt

@@ -22,7 +22,7 @@ internal class DefaultLiveObjects(internal val channelName: String, internal val
    */
   internal val objectsPool = ObjectsPool(this)
 
-  internal var state = ObjectsState.INITIALIZED
+  internal var state = ObjectsState.Initialized
 
   /**
    * @spec RTO4 - Used for handling object messages and object sync messages
@@ -155,7 +155,7 @@ internal class DefaultLiveObjects(internal val channelName: String, internal val
           Log.v(tag, "Objects.onAttached() channel=$channelName, hasObjects=$hasObjects")
 
           // RTO4a
-          val fromInitializedState = this@DefaultLiveObjects.state == ObjectsState.INITIALIZED
+          val fromInitializedState = this@DefaultLiveObjects.state == ObjectsState.Initialized
           if (hasObjects || fromInitializedState) {
             // should always start a new sync sequence if we're in the initialized state, no matter the HAS_OBJECTS flag value.
             // this guarantees we emit both "syncing" -> "synced" events in that order.

live-objects/src/main/kotlin/io/ably/lib/objects/ObjectsManager.kt

@@ -27,7 +27,7 @@ internal class ObjectsManager(private val liveObjects: DefaultLiveObjects): Obje
    * @spec RTO8 - Buffers messages if not synced, applies immediately if synced
    */
   internal fun handleObjectMessages(objectMessages: List<ObjectMessage>) {
-    if (liveObjects.state != ObjectsState.SYNCED) {
+    if (liveObjects.state != ObjectsState.Synced) {
       // RTO7 - The client receives object messages in realtime over the channel concurrently with the sync sequence.
       // Some of the incoming object messages may have already been applied to the objects described in
       // the sync sequence, but others may not; therefore we must buffer these messages so that we can apply
@@ -77,7 +77,7 @@ internal class ObjectsManager(private val liveObjects: DefaultLiveObjects): Obje
     bufferedObjectOperations.clear() // RTO5a2b
     syncObjectsDataPool.clear() // RTO5a2a
     currentSyncId = syncId
-    stateChange(ObjectsState.SYNCING, false)
+    stateChange(ObjectsState.Syncing, false)
   }
 
   /**
@@ -95,7 +95,7 @@ internal class ObjectsManager(private val liveObjects: DefaultLiveObjects): Obje
     bufferedObjectOperations.clear() // RTO5c5
     syncObjectsDataPool.clear() // RTO5c4
     currentSyncId = null // RTO5c3
-    stateChange(ObjectsState.SYNCED, deferStateEvent)
+    stateChange(ObjectsState.Synced, deferStateEvent)
   }
 
   /**

live-objects/src/main/kotlin/io/ably/lib/objects/ObjectsState.kt

@@ -10,9 +10,9 @@ import kotlinx.coroutines.*
  * @spec RTO2 - enum representing objects state
  */
 internal enum class ObjectsState {
-  INITIALIZED,
-  SYNCING,
-  SYNCED
+  Initialized,
+  Syncing,
+  Synced
 }
 
 /**
@@ -21,9 +21,9 @@ internal enum class ObjectsState {
  * INITIALIZED maps to null (no event), while SYNCING and SYNCED map to their respective events.
  */
 private val objectsStateToEventMap = mapOf(
-  ObjectsState.INITIALIZED to null,
-  ObjectsState.SYNCING to ObjectsStateEvent.SYNCING,
-  ObjectsState.SYNCED to ObjectsStateEvent.SYNCED
+  ObjectsState.Initialized to null,
+  ObjectsState.Syncing to ObjectsStateEvent.SYNCING,
+  ObjectsState.Synced to ObjectsStateEvent.SYNCED
 )
 
 /**
@@ -82,7 +82,7 @@ internal abstract class ObjectsStateCoordinator : ObjectsStateChange, HandlesObj
   }
 
   override suspend fun ensureSynced(currentState: ObjectsState) {
-    if (currentState != ObjectsState.SYNCED) {
+    if (currentState != ObjectsState.Synced) {
       val deferred = CompletableDeferred<Unit>()
       internalObjectStateEmitter.once(ObjectsStateEvent.SYNCED) {
         Log.v(tag, "Objects state changed to SYNCED, resuming ensureSynced")

live-objects/src/test/kotlin/io/ably/lib/objects/integration/DefaultLiveObjectsTest.kt

@@ -36,7 +36,7 @@ class DefaultLiveObjectsTest : IntegrationTest() {
     val objects = channel.objects
     assertNotNull(objects)
 
-    assertEquals(ObjectsState.INITIALIZED, objects.State, "Initial state should be INITIALIZED")
+    assertEquals(ObjectsState.Initialized, objects.State, "Initial state should be INITIALIZED")
 
     val syncStates = mutableListOf<ObjectsStateEvent>()
     objects.on(ObjectsStateEvent.SYNCING) {

live-objects/src/test/kotlin/io/ably/lib/objects/unit/objects/DefaultLiveObjectsTest.kt

@@ -34,7 +34,7 @@ class DefaultLiveObjectsTest {
     // RTO4a - If the HAS_OBJECTS flag is 1, the server will shortly perform an OBJECT_SYNC sequence
     defaultLiveObjects.handleStateChange(ChannelState.attached, true)
 
-    assertWaiter { defaultLiveObjects.state == ObjectsState.SYNCING }
+    assertWaiter { defaultLiveObjects.state == ObjectsState.Syncing }
 
     // It is expected that the client will start a new sync sequence
     verify(exactly = 1) {
@@ -59,7 +59,7 @@ class DefaultLiveObjectsTest {
     defaultLiveObjects.handleStateChange(ChannelState.attached, false)
 
     // Verify expected outcomes
-    assertWaiter { defaultLiveObjects.state == ObjectsState.SYNCED } // RTO4b4
+    assertWaiter { defaultLiveObjects.state == ObjectsState.Synced } // RTO4b4
 
     verify(exactly = 1) {
       defaultLiveObjects.objectsPool.resetToInitialPool(true)
@@ -80,7 +80,7 @@ class DefaultLiveObjectsTest {
     val defaultLiveObjects = getDefaultLiveObjectsWithMockedDeps()
 
     // Ensure we're in INITIALIZED state
-    defaultLiveObjects.state = ObjectsState.INITIALIZED
+    defaultLiveObjects.state = ObjectsState.Initialized
 
     // RTO4a - Should start sync even with HAS_OBJECTS flag false when in INITIALIZED state
     defaultLiveObjects.handleStateChange(ChannelState.attached, false)

live-objects/src/test/kotlin/io/ably/lib/objects/unit/objects/ObjectsManagerTest.kt

@@ -17,7 +17,7 @@ class ObjectsManagerTest {
   @Test
   fun `(RTO5) ObjectsManager should handle object sync messages`() {
     val defaultLiveObjects = getDefaultLiveObjectsWithMockedDeps()
-    assertEquals(ObjectsState.INITIALIZED, defaultLiveObjects.state, "Initial state should be INITIALIZED")
+    assertEquals(ObjectsState.Initialized, defaultLiveObjects.state, "Initial state should be INITIALIZED")
 
     val objectsManager = defaultLiveObjects.ObjectsManager
 
@@ -72,7 +72,7 @@ class ObjectsManagerTest {
     assertEquals("counter:testObject@2", newlyCreatedObjects[0].objectId)
     assertEquals("map:testObject@3", newlyCreatedObjects[1].objectId)
 
-    assertEquals(ObjectsState.SYNCED, defaultLiveObjects.state, "State should be SYNCED after sync sequence")
+    assertEquals(ObjectsState.Synced, defaultLiveObjects.state, "State should be SYNCED after sync sequence")
     // After sync `counter:testObject@4` will be removed from pool
     assertNull(objectsPool.get("counter:testObject@4"))
     assertEquals(4, objectsPool.size(), "Objects pool should contain 4 objects after sync including root")
@@ -97,7 +97,7 @@ class ObjectsManagerTest {
   @Test
   fun `(RTO8) ObjectsManager should apply object operation when state is synced`() {
     val defaultLiveObjects = getDefaultLiveObjectsWithMockedDeps()
-    defaultLiveObjects.state = ObjectsState.SYNCED // Ensure we're in SYNCED state
+    defaultLiveObjects.state = ObjectsState.Synced // Ensure we're in SYNCED state
 
     val objectsManager = defaultLiveObjects.ObjectsManager
 
@@ -165,7 +165,7 @@ class ObjectsManagerTest {
   @Test
   fun `(RTO7) ObjectsManager should buffer operations when not in sync, apply them after synced`() {
     val defaultLiveObjects = getDefaultLiveObjectsWithMockedDeps()
-    assertEquals(ObjectsState.INITIALIZED, defaultLiveObjects.state, "Initial state should be INITIALIZED")
+    assertEquals(ObjectsState.Initialized, defaultLiveObjects.state, "Initial state should be INITIALIZED")
 
     val objectsManager = defaultLiveObjects.ObjectsManager
     assertEquals(0, objectsManager.BufferedObjectOperations.size, "RTO7a1 - Initial buffer should be empty")
@@ -176,7 +176,7 @@ class ObjectsManagerTest {
     mockZeroValuedObjects()
 
     // Set state to SYNCING
-    defaultLiveObjects.state = ObjectsState.SYNCING
+    defaultLiveObjects.state = ObjectsState.Syncing
 
     val objectMessage = ObjectMessage(
       id = "testId",