ECO-5447] Added calculateUpdateFromDataDiff method to CounterManager

- Added extra assertion for deleting of "valuesMap"

Author: sacOO7

live-objects/src/main/kotlin/io/ably/lib/objects/type/livecounter/DefaultLiveCounter.kt

@@ -80,7 +80,7 @@ internal class DefaultLiveCounter private constructor(
   }
 
   override fun clearData(): LiveCounterUpdate {
-    return LiveCounterUpdate(data.get()).apply { data.set(0.0) }
+    return liveCounterManager.calculateUpdateFromDataDiff(data.get(), 0.0).apply { data.set(0.0) }
   }
 
   override fun notifyUpdated(update: LiveObjectUpdate) {

live-objects/src/main/kotlin/io/ably/lib/objects/type/livecounter/LiveCounterManager.kt

@@ -33,7 +33,7 @@ internal class LiveCounterManager(private val liveCounter: DefaultLiveCounter):
       }
     }
 
-    return LiveCounterUpdate(liveCounter.data.get() - previousData)
+    return calculateUpdateFromDataDiff(previousData, liveCounter.data.get())
   }
 
   /**
@@ -85,6 +85,10 @@ internal class LiveCounterManager(private val liveCounter: DefaultLiveCounter):
     return LiveCounterUpdate(amount)
   }
 
+  internal fun calculateUpdateFromDataDiff(prevData: Double, newData: Double): LiveCounterUpdate {
+    return LiveCounterUpdate(newData - prevData)
+  }
+
   /**
    * @spec RTLC10 - Merges initial data from create operation
    */

live-objects/src/test/kotlin/io/ably/lib/objects/integration/DefaultLiveObjectsTest.kt

@@ -190,7 +190,7 @@ class DefaultLiveObjectsTest : IntegrationTest() {
     assertWaiter { rootMap.size() == 5L } // Wait for the removal to complete
     assertNull(rootMap.get("referencedCounter")) // Should be null after removal
     assertEquals(1, counterUpdates.size) // Should have received one update for deletion
-    assertEquals(20.0, counterUpdates[0]) // The update should indicate the counter was removed
+    assertEquals(-20.0, counterUpdates[0]) // The update should indicate counter was removed with value 20
 
     // Remove the "referencedMap" from the root map
     val referencedMap = rootMap.get("referencedMap") as LiveMap
@@ -212,5 +212,28 @@ class DefaultLiveObjectsTest : IntegrationTest() {
     assertEquals(1, updatedMap.size) // Should have one change
     assertEquals("counterKey", updatedMap.keys.first()) // The change should be for the "counterKey"
     assertEquals(LiveMapUpdate.Change.REMOVED, updatedMap.values.first()) // Should indicate removal
+
+    // Remove the "valuesMap" from the root map
+    val valuesMap = rootMap.get("valuesMap") as LiveMap
+    assertNotNull(valuesMap)
+    // Subscribe to map updates to verify removal
+    val valuesMapUpdates = mutableListOf<Map<String, LiveMapUpdate.Change>>()
+    valuesMap.subscribe { event ->
+      valuesMapUpdates.add(event.update)
+    }
+
+    // Simulate the deletion of the valuesMap object
+    channel.objects.simulateObjectDelete(valuesMap as DefaultLiveMap)
+
+    assertWaiter { rootMap.size() == 3L } // Wait for the removal to complete
+    assertNull(rootMap.get("valuesMap")) // Should be null after removal
+    assertEquals(1, valuesMapUpdates.size) // Should have received one update for deletion
+
+    val updatedValuesMap = valuesMapUpdates.first()
+    assertEquals(13, updatedValuesMap.size) // Should have 13 changes (one for each entry in valuesMap)
+    // Verify that all entries in valuesMap were marked as REMOVED
+    updatedValuesMap.values.forEach { change ->
+      assertEquals(LiveMapUpdate.Change.REMOVED, change)
+    }
   }
 }