Skip to content

Commit 86c08f6

Browse files
committed
[ECO-5458] Updated ChangeEmitter implementations to be type safe
1 parent ae81bbc commit 86c08f6

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

live-objects/src/main/kotlin/io/ably/lib/objects/type/livecounter/LiveCounterChangeCoordinator.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ private class LiveCounterChangeEmitter : EventEmitter<LiveCounterUpdate, LiveCou
4242

4343
override fun apply(listener: LiveCounterChange.Listener?, event: LiveCounterUpdate?, vararg args: Any?) {
4444
try {
45-
listener?.onUpdated(event!!)
45+
event?.let { listener?.onUpdated(it) }
46+
?: Log.w(tag, "Null event passed to listener callback")
4647
} catch (t: Throwable) {
4748
Log.e(tag, "Error occurred while executing listener callback for event: $event", t)
4849
}

live-objects/src/main/kotlin/io/ably/lib/objects/type/livemap/LiveMapChangeCoordinator.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ private class LiveMapChangeEmitter : EventEmitter<LiveMapUpdate, LiveMapChange.L
4242

4343
override fun apply(listener: LiveMapChange.Listener?, event: LiveMapUpdate?, vararg args: Any?) {
4444
try {
45-
listener?.onUpdated(event!!)
45+
event?.let { listener?.onUpdated(it) }
46+
?: Log.w(tag, "Null event passed to listener callback")
4647
} catch (t: Throwable) {
4748
Log.e(tag, "Error occurred while executing listener callback for event: $event", t)
4849
}

0 commit comments

Comments
 (0)