[AIT-1037] Refactored object package name to liveobjects#1220
Open
sacOO7 wants to merge 2 commits into
Open
Conversation
WalkthroughAll LiveObjects public Java interfaces, Kotlin implementations, serialization helpers, test files, Gradle task registrations, and CI workflow commands are renamed from ChangesLiveObjects Package Rename and ChannelBase Wiring Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The change is high-volume but almost entirely homogeneous package-declaration and import-path substitutions. The only non-mechanical change requiring careful inspection is the Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/src/main/java/io/ably/lib/liveobjects/Subscription.java (1)
1-1: 🗄️ Data Integrity & Integration | 🔵 TrivialCall out this package move in the migration notes.
This changes the FQCN of a public interface, so downstream imports and any reflective lookups against
io.ably.lib.object.*will break. Please make sure the release notes or migration guide spell out the old and new package names.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/src/main/java/io/ably/lib/liveobjects/Subscription.java` at line 1, The public interface Subscription has moved packages, changing its FQCN from io.ably.lib.object.* to io.ably.lib.liveobjects.*, so update the migration/release notes to explicitly call out the old and new package names. Make sure the notes mention that downstream imports and any reflective lookups using the old io.ably.lib.object path will need to be updated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lib/src/main/java/io/ably/lib/liveobjects/Subscription.java`:
- Line 1: The public interface Subscription has moved packages, changing its
FQCN from io.ably.lib.object.* to io.ably.lib.liveobjects.*, so update the
migration/release notes to explicitly call out the old and new package names.
Make sure the notes mention that downstream imports and any reflective lookups
using the old io.ably.lib.object path will need to be updated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 71cef35f-339b-44e7-a166-3df32caa7086
📒 Files selected for processing (116)
.github/workflows/check.yml.github/workflows/integration-test.ymljava/src/main/java/io/ably/lib/realtime/Channel.javalib/src/main/java/io/ably/lib/liveobjects/LiveObjectsPlugin.javalib/src/main/java/io/ably/lib/liveobjects/RealtimeObject.javalib/src/main/java/io/ably/lib/liveobjects/Subscription.javalib/src/main/java/io/ably/lib/liveobjects/ValueType.javalib/src/main/java/io/ably/lib/liveobjects/adapter/AblyClientAdapter.javalib/src/main/java/io/ably/lib/liveobjects/adapter/Adapter.javalib/src/main/java/io/ably/lib/liveobjects/adapter/package-info.javalib/src/main/java/io/ably/lib/liveobjects/instance/Instance.javalib/src/main/java/io/ably/lib/liveobjects/instance/InstanceListener.javalib/src/main/java/io/ably/lib/liveobjects/instance/InstanceSubscriptionEvent.javalib/src/main/java/io/ably/lib/liveobjects/instance/package-info.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/BinaryInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/BooleanInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/JsonArrayInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/JsonObjectInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/LiveCounterInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/LiveMapInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/NumberInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/StringInstance.javalib/src/main/java/io/ably/lib/liveobjects/instance/types/package-info.javalib/src/main/java/io/ably/lib/liveobjects/message/CounterCreate.javalib/src/main/java/io/ably/lib/liveobjects/message/CounterInc.javalib/src/main/java/io/ably/lib/liveobjects/message/MapClear.javalib/src/main/java/io/ably/lib/liveobjects/message/MapCreate.javalib/src/main/java/io/ably/lib/liveobjects/message/MapRemove.javalib/src/main/java/io/ably/lib/liveobjects/message/MapSet.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectData.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectDelete.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectMessage.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectOperation.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectOperationAction.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectsMapEntry.javalib/src/main/java/io/ably/lib/liveobjects/message/ObjectsMapSemantics.javalib/src/main/java/io/ably/lib/liveobjects/message/package-info.javalib/src/main/java/io/ably/lib/liveobjects/package-info.javalib/src/main/java/io/ably/lib/liveobjects/path/PathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/PathObjectListener.javalib/src/main/java/io/ably/lib/liveobjects/path/PathObjectSubscriptionEvent.javalib/src/main/java/io/ably/lib/liveobjects/path/PathObjectSubscriptionOptions.javalib/src/main/java/io/ably/lib/liveobjects/path/package-info.javalib/src/main/java/io/ably/lib/liveobjects/path/types/BinaryPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/BooleanPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/JsonArrayPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/JsonObjectPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/LiveCounterPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/LiveMapPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/NumberPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/StringPathObject.javalib/src/main/java/io/ably/lib/liveobjects/path/types/package-info.javalib/src/main/java/io/ably/lib/liveobjects/serialization/ObjectJsonSerializer.javalib/src/main/java/io/ably/lib/liveobjects/serialization/ObjectSerializer.javalib/src/main/java/io/ably/lib/liveobjects/state/ObjectStateChange.javalib/src/main/java/io/ably/lib/liveobjects/state/ObjectStateEvent.javalib/src/main/java/io/ably/lib/liveobjects/value/LiveCounter.javalib/src/main/java/io/ably/lib/liveobjects/value/LiveMap.javalib/src/main/java/io/ably/lib/liveobjects/value/LiveMapValue.javalib/src/main/java/io/ably/lib/liveobjects/value/package-info.javalib/src/main/java/io/ably/lib/object/instance/package-info.javalib/src/main/java/io/ably/lib/object/package-info.javalib/src/main/java/io/ably/lib/object/path/package-info.javalib/src/main/java/io/ably/lib/realtime/AblyRealtime.javalib/src/main/java/io/ably/lib/realtime/ChannelBase.javalib/src/main/java/io/ably/lib/realtime/Connection.javalib/src/main/java/io/ably/lib/transport/ConnectionManager.javalib/src/main/java/io/ably/lib/types/ProtocolMessage.javaliveobjects/build.gradle.ktsliveobjects/src/main/kotlin/io/ably/lib/liveobjects/DefaultRealtimeObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/Errors.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/Helpers.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/Utils.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/DefaultInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/DefaultInstanceSubscriptionEvent.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultBinaryInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultBooleanInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultJsonArrayInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultJsonObjectInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultLiveCounterInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultLiveMapInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultNumberInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultStringInstance.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/message/DefaultObjectMessage.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/message/WireObjectMessage.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/DefaultPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/DefaultPathObjectSubscriptionEvent.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultBinaryPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultBooleanPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultJsonArrayPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultJsonObjectPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultLiveCounterPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultLiveMapPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultNumberPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultStringPathObject.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/DefaultSerialization.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/JsonSerialization.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/MsgpackSerialization.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/DefaultLiveCounter.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/DefaultLiveMap.ktliveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/ResolvedValue.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/TestUtils.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/DefaultRealtimeObjectTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/PayloadBuilder.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/RestObjects.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/CounterFixtures.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/DataFixtures.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/MapFixtures.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/setup/IntegrationTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/setup/Sandbox.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/HelpersTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/ObjectMessageSerializationTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/ObjectMessageSizeTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/TestHelpers.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/UtilsTest.ktliveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/fixtures/ObjectMessageFixtures.kt
💤 Files with no reviewable changes (3)
- lib/src/main/java/io/ably/lib/object/instance/package-info.java
- lib/src/main/java/io/ably/lib/object/path/package-info.java
- lib/src/main/java/io/ably/lib/object/package-info.java
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the LiveObjects (typed Objects) API namespace across the codebase from io.ably.lib.object / Kotlin-escaped ``io.ably.lib.object``` to the domain-specific io.ably.lib.liveobjects`, updating production code, tests, Gradle test tasks, and CI workflows to match the new package structure and avoid `java.lang.Object` naming collisions.
Changes:
- Renamed LiveObjects public API packages (path/instance/value/message/serialization/state) to
io.ably.lib.liveobjectsacross Java and Kotlin sources. - Updated LiveObjects unit/integration test packages and Gradle test filters, and renamed Gradle tasks + CI workflow invocations accordingly.
- Wired
ChannelBase.objectto the LiveObjects plugin instance when available (removing the prior TODO-style placeholder behavior).
Reviewed changes
Copilot reviewed 117 out of 117 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/UtilsTest.kt | Update test package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/TestHelpers.kt | Update test helpers imports + mockkStatic target to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/ObjectMessageSizeTest.kt | Update message-size test imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/ObjectMessageSerializationTest.kt | Update serialization test imports/fixtures to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/HelpersTest.kt | Update helper test imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/unit/fixtures/ObjectMessageFixtures.kt | Update fixture package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/TestUtils.kt | Update test utils package to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/setup/Sandbox.kt | Update integration setup package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/setup/IntegrationTest.kt | Update integration base test package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/RestObjects.kt | Update integration helper package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/PayloadBuilder.kt | Update payload builder imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/MapFixtures.kt | Update fixture package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/DataFixtures.kt | Update fixture package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/helpers/fixtures/CounterFixtures.kt | Update fixture package/imports to liveobjects. |
| liveobjects/src/test/kotlin/io/ably/lib/liveobjects/integration/DefaultRealtimeObjectTest.kt | Update integration test package/imports to liveobjects. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/ResolvedValue.kt | Move value-resolution model under liveobjects.value. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/DefaultLiveMap.kt | Move DefaultLiveMap implementation package to liveobjects.value. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/value/DefaultLiveCounter.kt | Move DefaultLiveCounter implementation package to liveobjects.value. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/Utils.kt | Move utilities to io.ably.lib.liveobjects. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/MsgpackSerialization.kt | Move msgpack serializers to liveobjects.serialization. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/JsonSerialization.kt | Move JSON serializers to liveobjects.serialization. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/serialization/DefaultSerialization.kt | Move default serializer implementation to liveobjects.serialization. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultStringPathObject.kt | Move string path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultNumberPathObject.kt | Move number path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultLiveMapPathObject.kt | Move map path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultLiveCounterPathObject.kt | Move counter path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultJsonObjectPathObject.kt | Move JSON object path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultJsonArrayPathObject.kt | Move JSON array path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultBooleanPathObject.kt | Move boolean path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/types/DefaultBinaryPathObject.kt | Move binary path object implementation to liveobjects.path.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/DefaultPathObjectSubscriptionEvent.kt | Move subscription event impl to liveobjects.path. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/path/DefaultPathObject.kt | Move path object implementation + imports to liveobjects.path. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/message/WireObjectMessage.kt | Move wire message model to liveobjects.message. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/message/DefaultObjectMessage.kt | Move default object message implementation to liveobjects.message. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultStringInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultNumberInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultLiveMapInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultLiveCounterInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultJsonObjectInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultJsonArrayInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultBooleanInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/types/DefaultBinaryInstance.kt | Move instance implementations to liveobjects.instance.types. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/DefaultInstanceSubscriptionEvent.kt | Move instance subscription event impl to liveobjects.instance. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/instance/DefaultInstance.kt | Move instance core implementation to liveobjects.instance. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/Helpers.kt | Move helper utilities to io.ably.lib.liveobjects. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/Errors.kt | Move error types/helpers to io.ably.lib.liveobjects. |
| liveobjects/src/main/kotlin/io/ably/lib/liveobjects/DefaultRealtimeObject.kt | Move DefaultRealtimeObject implementation to io.ably.lib.liveobjects. |
| liveobjects/build.gradle.kts | Rename test tasks and update test filters to io.ably.lib.liveobjects.*. |
| lib/src/main/java/io/ably/lib/types/ProtocolMessage.java | Update serializer imports to io.ably.lib.liveobjects.serialization. |
| lib/src/main/java/io/ably/lib/transport/ConnectionManager.java | Update LiveObjectsPlugin import to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/realtime/Connection.java | Update LiveObjectsPlugin import to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/realtime/ChannelBase.java | Update imports and set this.object from LiveObjectsPlugin instance when present. |
| lib/src/main/java/io/ably/lib/realtime/AblyRealtime.java | Update LiveObjectsPlugin import to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/object/path/package-info.java | Remove old package-info (moved under io.ably.lib.liveobjects.path). |
| lib/src/main/java/io/ably/lib/object/package-info.java | Remove old root package-info (moved under io.ably.lib.liveobjects). |
| lib/src/main/java/io/ably/lib/object/instance/package-info.java | Remove old instance package-info (moved under io.ably.lib.liveobjects.instance). |
| lib/src/main/java/io/ably/lib/liveobjects/ValueType.java | Move ValueType to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/liveobjects/value/package-info.java | Update value package-info to io.ably.lib.liveobjects.value. |
| lib/src/main/java/io/ably/lib/liveobjects/value/LiveMapValue.java | Move LiveMapValue to io.ably.lib.liveobjects.value. |
| lib/src/main/java/io/ably/lib/liveobjects/value/LiveMap.java | Update reflection implementation class name to io.ably.lib.liveobjects.value.DefaultLiveMap. |
| lib/src/main/java/io/ably/lib/liveobjects/value/LiveCounter.java | Update reflection implementation class name to io.ably.lib.liveobjects.value.DefaultLiveCounter. |
| lib/src/main/java/io/ably/lib/liveobjects/Subscription.java | Move Subscription to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/liveobjects/state/ObjectStateEvent.java | Move state event types to io.ably.lib.liveobjects.state. |
| lib/src/main/java/io/ably/lib/liveobjects/state/ObjectStateChange.java | Move state change types to io.ably.lib.liveobjects.state. |
| lib/src/main/java/io/ably/lib/liveobjects/serialization/ObjectSerializer.java | Move serializer interface + reflection target FQCN to io.ably.lib.liveobjects.serialization. |
| lib/src/main/java/io/ably/lib/liveobjects/serialization/ObjectJsonSerializer.java | Move JSON adapter to io.ably.lib.liveobjects.serialization. |
| lib/src/main/java/io/ably/lib/liveobjects/RealtimeObject.java | Move RealtimeObject to io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/StringPathObject.java | Move typed path API to io.ably.lib.liveobjects.path.types. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/package-info.java | Update typed path package-info to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/NumberPathObject.java | Move typed path API to io.ably.lib.liveobjects.path.types. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/LiveMapPathObject.java | Move typed path API + value imports to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/LiveCounterPathObject.java | Move typed path API to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/JsonObjectPathObject.java | Move typed path API to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/JsonArrayPathObject.java | Move typed path API to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/BooleanPathObject.java | Move typed path API to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/types/BinaryPathObject.java | Move typed path API to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/path/PathObjectSubscriptionOptions.java | Move path subscription options to io.ably.lib.liveobjects.path. |
| lib/src/main/java/io/ably/lib/liveobjects/path/PathObjectSubscriptionEvent.java | Move path subscription event to io.ably.lib.liveobjects.path. |
| lib/src/main/java/io/ably/lib/liveobjects/path/PathObjectListener.java | Move path listener to io.ably.lib.liveobjects.path. |
| lib/src/main/java/io/ably/lib/liveobjects/path/PathObject.java | Move path root interface to io.ably.lib.liveobjects.path. |
| lib/src/main/java/io/ably/lib/liveobjects/path/package-info.java | Add new path package-info under io.ably.lib.liveobjects.path. |
| lib/src/main/java/io/ably/lib/liveobjects/package-info.java | Add new root package-info under io.ably.lib.liveobjects. |
| lib/src/main/java/io/ably/lib/liveobjects/message/package-info.java | Update message package-info to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectsMapSemantics.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectsMapEntry.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectOperationAction.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectOperation.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectMessage.java | Move message model and update subscription-event links. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectDelete.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/ObjectData.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/MapSet.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/MapRemove.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/MapCreate.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/MapClear.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/CounterInc.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/message/CounterCreate.java | Move message model to io.ably.lib.liveobjects.message. |
| lib/src/main/java/io/ably/lib/liveobjects/LiveObjectsPlugin.java | Move plugin interface to io.ably.lib.liveobjects and update reflection FQCN. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/StringInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/package-info.java | Update typed instance package-info to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/NumberInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/LiveMapInstance.java | Move typed instance API + value imports to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/LiveCounterInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/JsonObjectInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/JsonArrayInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/BooleanInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/types/BinaryInstance.java | Move typed instance API to io.ably.lib.liveobjects.instance.types. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/package-info.java | Add new instance package-info under io.ably.lib.liveobjects.instance. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/InstanceSubscriptionEvent.java | Move instance subscription event to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/InstanceListener.java | Move instance listener to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/instance/Instance.java | Move instance root interface to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/adapter/package-info.java | Update adapter package-info to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/adapter/Adapter.java | Move adapter implementation to new namespace. |
| lib/src/main/java/io/ably/lib/liveobjects/adapter/AblyClientAdapter.java | Move adapter interface to new namespace. |
| java/src/main/java/io/ably/lib/realtime/Channel.java | Update LiveObjectsPlugin import for Java artifact. |
| android/src/main/java/io/ably/lib/realtime/Channel.java | Update LiveObjectsPlugin import for Android artifact. |
| .github/workflows/integration-test.yml | Update CI to call renamed Gradle integration test task. |
| .github/workflows/check.yml | Update CI to call renamed Gradle unit test task. |
Comments suppressed due to low confidence (4)
lib/src/main/java/io/ably/lib/liveobjects/LiveObjectsPlugin.java:90
- LiveObjects plugin initialization is hard-coded to reflectively load
io.ably.lib.liveobjects.DefaultLiveObjectsPlugin, but there is no such implementation class in this repository (and switching the FQCN will also prevent loading olderio.ably.lib.object.DefaultLiveObjectsPluginimplementations). This means LiveObjects will silently stay unavailable even when the LiveObjects implementation jar is present unless the implementation class name matches exactly; consider adding backwards-compatible fallback (and/or ensure the implementation class exists under the new package).
lib/src/main/java/io/ably/lib/liveobjects/message/ObjectMessage.java:11 - This Javadoc block was partially updated, but it still references the old
io.ably.lib.object.messagepackage later in the comment (nowio.ably.lib.liveobjects.message).
liveobjects/src/main/kotlin/io/ably/lib/liveobjects/message/WireObjectMessage.kt:1 - The KDoc still references the old public API package name
io.ably.lib.object.message(nowio.ably.lib.liveobjects.message).
lib/src/main/java/io/ably/lib/liveobjects/adapter/AblyClientAdapter.java:1 - Javadoc still calls this the adapter for the
io.ably.lib.objectAPI; after the rename it should referenceio.ably.lib.liveobjects.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sacOO7
changed the title
object package name to liveobjects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examplesmodules will be addressed as a part of https://ably.atlassian.net/browse/AIT-1038Recommended Naming: liveobjects 🥇
Example: io.ably.liveobjects (or com.ably.liveobjects)
Why: It removes all ambiguity, exactly matches the Ably product name you are fetching from the docs, and completely avoids the java.lang.Object naming collision.
Summary by CodeRabbit
liveobjectsnamespace.