You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-[ ] it has missed out some of the primitiveKeyData (e.g. max integer)
2
-
-[ ] the primitiveKeyData need DRYing up
2
+
-[ ] the primitiveKeyData need DRYing up — and I need to understand what types they should be
3
3
-[ ] some of the code that checks unsubscribe might be a bit racy — e.g. it might just be that you didn't see an update yet because you dispatched its handling into a `Task`
4
+
-[ ] there are a bunch of `if case` statements in the tests which make me worry that some tests might end up being no-ops
0 commit comments