only update attachSerial for non-resumed attaches#503
Open
SimonWoolf wants to merge 1 commit into
Open
Conversation
Member
|
@ttypic does this need a UTS update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the spec said to update
attachSerialwhenever you get an ATTACHED.This doesn't make sense. attachSerial is used for
untilAttachhistory, which is used to get history that is contiguous to the stream of realtime messages. If you get an attached with resumed=true because of a brief disconnection, that didn't reset your period of message continuity, so it shouldn't change the point up to which untilAttach gives you history!