raise an error status 400 if scan could not be fetched

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

component_catalog/api.py

@@ -879,6 +879,11 @@ class ScanDataUnavailable(APIException):
     default_detail = "Scan data is not available"
 
 
+class ScanFetchError(APIException):
+    status_code = status.HTTP_400_BAD_REQUEST
+    default_detail = "Could not fetch scan data"
+
+
 class PackageViewSet(
     SendAboutFilesMixin,
     AboutCodeFilesActionMixin,
@@ -965,6 +970,8 @@ def scan_results(self, request, uuid):
         project_uuid = project_info.get("uuid")
         scan_results_url = scancodeio.get_scan_action_url(project_uuid, "results")
         scan_results = scancodeio.fetch_scan_data(scan_results_url)
+        if not scan_results:
+            raise ScanFetchError()
 
         return Response(scan_results)
 

component_catalog/tests/test_api.py

@@ -1532,6 +1532,13 @@ def test_api_package_viewset_scan_results_action(
         action_url = reverse("api_v2:package-scan-results", args=[self.package1.uuid])
         mock_is_available.return_value = True
         mock_get_project_info.return_value = {"uuid": "abcdef"}
+
+        mock_fetch_scan_data.return_value = None
+        response = self.client.get(action_url)
+        self.assertEqual(400, response.status_code)
+        error = {'detail': ErrorDetail(string='Could not fetch scan data', code='error')}
+        self.assertEqual(error, response.data)
+
         mock_fetch_scan_data.return_value = {"results": ""}
         response = self.client.get(action_url)
         self.assertEqual(200, response.status_code)