add filter by policy rule

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

policy/rules.py

@@ -22,6 +22,10 @@ def count_violations(self, product, threshold, parameters):
         """Count objects violating the rule for the given product."""
         raise NotImplementedError
 
+    def get_package_filter(self):
+        """Return queryset filter kwargs for ProductPackage to identify violating packages."""
+        return {}
+
 
 class PackageBaseRule(BaseRule):
     """Base for rules that count packages matching a fixed filter within a product."""
@@ -38,6 +42,9 @@ def count_violations(self, product, threshold, parameters):
 
         return count if count > threshold else 0
 
+    def get_package_filter(self):
+        return {f"package__{key}": value for key, value in self.package_filter.items()}
+
 
 class LicensePolicyErrorRule(PackageBaseRule):
     rule_type = "license_policy_error"
@@ -74,6 +81,9 @@ class VulnerabilityDetectedRule(BaseRule):
         "min_risk_score": "Minimum risk score (0.0-10.0). Default: any vulnerability.",
     }
 
+    def get_package_filter(self):
+        return {"package__risk_score__isnull": False}
+
     def count_violations(self, product, threshold, parameters):
         Package = apps.get_model("component_catalog", "package")
 

product_portfolio/filters.py

@@ -31,6 +31,7 @@
 from dje.widgets import DropDownRightWidget
 from dje.widgets import DropDownWidget
 from license_library.models import License
+from policy.rules import RULE_REGISTRY
 from product_portfolio.models import CodebaseResource
 from product_portfolio.models import Product
 from product_portfolio.models import ProductComponent
@@ -407,6 +408,7 @@ class ProductPackageFilterSet(BaseProductRelationFilterSet):
         field_name="package__usage_policy__compliance_alert",
         distinct=True,
     )
+    policy_rule = django_filters.CharFilter(method="filter_by_policy_rule")
 
     class Meta:
         model = ProductPackage
@@ -422,6 +424,13 @@ class Meta:
             "exploitability",
         ]
 
+    def filter_by_policy_rule(self, queryset, name, value):
+        """Filter packages that triggered the given policy rule type."""
+        handler = RULE_REGISTRY.get(value)
+        if not handler:
+            return queryset
+        return queryset.filter(**handler.get_package_filter())
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.filters["vulnerability_analyses__state"].extra["null_label"] = "(No values)"

product_portfolio/templates/product_portfolio/compliance/compliance_panels.html

@@ -250,7 +250,12 @@ <h3 class="fs-6 fw-medium mb-0">{% trans "Policy violations" %}</h3>
             <tr>
               <td>{{ violation.rule_label }}</td>
               <td class="text-body-secondary small">{{ violation.rule_description }}</td>
-              <td>{{ violation.violation_count }}</td>
+              <td>
+                <a href="{{ product_url }}?inventory-policy_rule={{ violation.rule_type }}#inventory"
+                   class="text-decoration-none">
+                  {{ violation.violation_count }}
+                </a>
+              </td>
               <td class="text-body-tertiary small">{{ violation.detected_date|date:"N j, Y" }}</td>
             </tr>
             {% endfor %}

product_portfolio/templates/product_portfolio/compliance/metric_cards.html

@@ -84,7 +84,7 @@
       {% else %}
         <div class="fs-4 fw-medium lh-sm text-danger">{{ policy_violation_count }}</div>
         <div class="text-body-tertiary fs-xs mt-1">
-          <a href="#policy-violations" class="text-body-tertiary text-decoration-none">
+          <a href="#policy-violations" class="text-decoration-none">
             {{ policy_violation_count }} {% trans "rule" %}{{ policy_violation_count|pluralize }} {% trans "triggered" %}
           </a>
         </div>