Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ Release notes
- Refine the way the PURL fragments are handled in searches.
https://github.com/aboutcode-org/dejacode/issues/286

- Fix an issue with ``urlize_target_blank`` when the URL contains curly braces.

### Version 5.2.1

- Fix the models documentation navigation.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% load i18n %}
{% load inject_preserved_filters from dje_tags %}
{% load urlize_target_blank from dje_tags %}
{% load naturaltime_short from dje_tags %}
<table id="object-list-table" class="table table-bordered table-striped table-md table-fixed-layout text-break packages-table">
{% if form or add_to_component_form %}
Expand Down
3 changes: 2 additions & 1 deletion dje/templatetags/dje_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from django.utils.html import format_html
from django.utils.html import urlize as _urlize
from django.utils.http import urlencode
from django.utils.safestring import mark_safe

register = Library()

Expand Down Expand Up @@ -139,7 +140,7 @@ def urlize_target_blank(value, autoescape=True):
else:
link = _urlize(value, nofollow=True, autoescape=autoescape)
link = link.replace("<a", '<a target="_blank"')
return format_html(link)
return mark_safe(link)


@register.filter
Expand Down
6 changes: 6 additions & 0 deletions dje/tests/test_templatetags.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ def test_dje_templatetags_urlize_target_blank_template_tag(self):
'<a target="_blank" href="ftp://domain.com" rel="noreferrer nofollow">'
"ftp://domain.com</a>",
),
(
"https://repo1.maven.org/maven2/{0/group_id}/{0.version}.jar",
'<a target="_blank" href="https://repo1.maven.org/maven2/%7B0/'
'group_id%7D/%7B0.version%7D.jar" rel="nofollow">'
"https://repo1.maven.org/maven2/{0/group_id}/{0.version}.jar</a>",
),
]

for url, expected in inputs:
Expand Down