packagedcode: remove unrelated changes from publiccode PR

Author: kumarasantosh

src/licensedcode/data/rules/ibpp_intro.RULE

@@ -706,7 +706,6 @@ def party_mapper(role, names=[], emails=[]):
             models.Party(type=models.party_person, email=email, role=role)
             for email in emails
         )
-    return ()
 
 
 def get_parties(gem_data):

src/licensedcode/data/rules/ibpp_ref.RULE

@@ -133,40 +133,6 @@ def get_authors(line):
 }
 
 
-def is_ruby_version_constant(value):
-    """
-    Return True if value looks like a Ruby constant expression
-    that cannot be resolved statically, such as:
-    Elasticsearch::API::VERSION or MyGem::VERSION
-
-    These are dynamic values that reference Ruby constants
-    and cannot be determined without executing the Ruby code.
-
-    For example:
-    >>> is_ruby_version_constant('Elasticsearch::API::VERSION')
-    True
-    >>> is_ruby_version_constant('MyGem::VERSION')
-    True
-    >>> is_ruby_version_constant('1.0.0')
-    False
-    >>> is_ruby_version_constant("'2.3.4'")
-    False
-    >>> is_ruby_version_constant(None)
-    False
-    """
-    if not value:
-        return False
-    # Ruby constants use :: as namespace separator
-    if '::' in value:
-        return True
-    # A bare constant starts with uppercase and has no dots/quotes
-    # e.g. VERSION (unlikely but possible)
-    stripped = value.strip('\'"')
-    if stripped and stripped[0].isupper() and '.' not in stripped:
-        return True
-    return False
-
-
 def parse_spec(location, package_type):
     """
     Return a mapping of data parsed from a podspec/gemspec/Pofile/Gemfile file
@@ -185,10 +151,6 @@ def parse_spec(location, package_type):
             parsed = parser(line=line)
             if parsed:
                 spec_data[attribute_name] = parsed
-    
-    version = spec_data.get('version')
-    if is_ruby_version_constant(version):
-        spec_data['version'] = None
 
     # description can be in single or multi-lines
     # There are many different ways to write description.

src/packagedcode/rubygems.py

@@ -374,30 +374,3 @@ def test_match_reference_license():
         must_exist=False,
     )
     check_json_scan(expected_loc, result_file, regen=REGEN_TEST_FIXTURES)
-
-
-def test_wt_ibpp_interference_is_detected_in_scan_output():
-    test_file = test_env.get_test_loc('datadriven/lic1/wt_ibpp_interference.md')
-    result_file = test_env.get_temp_file('json')
-    args = [
-        '--license',
-        '--license-text',
-        '--license-text-diagnostics',
-        '--license-diagnostics',
-        '--strip-root',
-        '--json', result_file,
-        test_file,
-    ]
-    run_scan_click(args, processes='1')
-
-    from commoncode.resource import VirtualCodebase
-
-    codebase = VirtualCodebase(result_file)
-    resource = codebase.get_resource(path='wt_ibpp_interference.md')
-
-    assert resource.detected_license_expression == 'bsd-1-clause AND ibpp'
-    assert any(
-        match['license_expression'] == 'ibpp'
-        for detection in resource.license_detections
-        for match in detection['matches']
-    )

src/packagedcode/spec.py

@@ -3,7 +3,7 @@
     "type": "gem",
     "namespace": null,
     "name": "github",
-    "version": null,
+    "version": "GitHub::VERSION",
     "qualifiers": {},
     "subpath": null,
     "primary_language": "Ruby",
@@ -48,7 +48,7 @@
     ],
     "keywords": [],
     "homepage_url": "https://github.com/defunkt/github-gem",
-    "download_url": null,
+    "download_url": "https://rubygems.org/downloads/github-GitHub::VERSION.gem",
     "size": null,
     "sha1": null,
     "md5": null,
@@ -162,10 +162,10 @@
         "extra_data": {}
       }
     ],
-    "repository_homepage_url": "https://rubygems.org/gems/github",
-    "repository_download_url": null,
-    "api_data_url": "https://rubygems.org/api/v1/versions/github.json",
+    "repository_homepage_url": "https://rubygems.org/gems/github/versions/GitHub::VERSION",
+    "repository_download_url": "https://rubygems.org/downloads/github-GitHub::VERSION.gem",
+    "api_data_url": "https://rubygems.org/api/v2/rubygems/github/versions/GitHub::VERSION.json",
     "datasource_id": "gemspec",
-    "purl": "pkg:gem/github"
+    "purl": "pkg:gem/github@GitHub::VERSION"
   }
 ]