Skip to content

Support SPDX License List 3.23#3653

Merged
AyanSinhaMahapatra merged 5 commits into
developfrom
update-spdx-license-list
Feb 20, 2024
Merged

Support SPDX License List 3.23#3653
AyanSinhaMahapatra merged 5 commits into
developfrom
update-spdx-license-list

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented Feb 14, 2024

Copy link
Copy Markdown
Member

Reference: aboutcode-org/scancode-licensedb#49

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Reference: aboutcode-org/scancode-licensedb#49
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Referemce: aboutcode-org/scancode-licensedb#49
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: aboutcode-org/scancode-licensedb#49
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Comment thread src/licensedcode/data/rules/fsfap-no-warranty-disclaimer_1.RULE Outdated
Comment thread src/licensedcode/data/rules/gtkbook_1.RULE Outdated

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few nits on copyrights... and good to merge otherwise!
Thanks

Comment thread src/licensedcode/data/rules/dec-3-clause_1.RULE Outdated
Comment thread src/licensedcode/data/rules/caldera-no-preamble_1.RULE Outdated
Comment thread src/licensedcode/data/rules/other-permissive_242.RULE
Comment thread src/licensedcode/data/rules/pnmstitch_1.RULE Outdated
Comment thread src/licensedcode/data/rules/softsurfer_2.RULE Outdated
Comment thread src/licensedcode/data/rules/sun-ppp_1.RULE Outdated
Comment thread src/licensedcode/data/rules/umich-merit_1.RULE
Comment thread src/licensedcode/data/rules/xkeyboard-config-zinoviev_1.RULE Outdated

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please our texts as-is and add add new rules with the SPDX texts rather than modifying our texts.

Comment thread src/licensedcode/data/licenses/drl-1.1.LICENSE Outdated
Comment thread src/licensedcode/data/licenses/hdparm.LICENSE Outdated
Comment thread src/licensedcode/data/licenses/paul-mackerras.LICENSE Outdated
Comment thread src/licensedcode/data/licenses/softsurfer.LICENSE Outdated
Comment thread src/licensedcode/data/licenses/tgppl-1.0.LICENSE
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra

Copy link
Copy Markdown
Member Author

@pombredanne thanks for the comments, updated them to preserve the original texts.

@DennisClark DennisClark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra I tried really hard to find problems, but did not succeed! This looks ready to go, thanks.

@AyanSinhaMahapatra

Copy link
Copy Markdown
Member Author

Thanks @DennisClark @pombredanne , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 9d466d3 into develop Feb 20, 2024
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-spdx-license-list branch February 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants