Update MSFT related URL rules#3717
Closed
swastkk wants to merge 1 commit intoaboutcode-org:developfrom
Closed
Conversation
Signed-off-by: swastkk <swastkk@gmail.com>
AyanSinhaMahapatra
requested changes
Jun 10, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
This is not what we want to do, see comments.
| --- | ||
|
|
||
| https://go.microsoft.com/fwlink/?linkid=529443 No newline at end of file | ||
| https://dotnet.microsoft.com/en-us/dotnet_library_license.htm No newline at end of file |
Member
There was a problem hiding this comment.
You've misunderstood entirely what we want to do here.
We don't want to change the rule text, we want to change the license_expression for this rule to ms-net-library-2019-06 as this is a license we now have in licenseDB and so this is not an unknown license reference.
Note that we cannot just change a license-expression by replacing, we have to deprecate this rule and create a new rule, see the comment in #3744 (comment) for example. As this is reference data and we want to preserve these rule names and links to these.
Member
|
ping |
Member
|
@swastkk I am closing this for now, as we need a new rule, not an updated of the old one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Tasks
Run tests locally to check for errors.