Skip to content

Update MSFT related URL rules #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swastkk wants to merge 1 commit into from
Closed

Update MSFT related URL rules #3717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/licensedcode/data/rules/unknown-license-reference_158.RULE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ ignorable_urls:
- https://go.microsoft.com/fwlink/?linkid=529443
---

https://go.microsoft.com/fwlink/?linkid=529443
https://dotnet.microsoft.com/en-us/dotnet_library_license.htm
Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've misunderstood entirely what we want to do here.

We don't want to change the rule text, we want to change the license_expression for this rule to ms-net-library-2019-06 as this is a license we now have in licenseDB and so this is not an unknown license reference.

Note that we cannot just change a license-expression by replacing, we have to deprecate this rule and create a new rule, see the comment in #3744 (comment) for example. As this is reference data and we want to preserve these rule names and links to these.