Fix the openssl-exception-lgpl-3.0-plus primary spdx_license_key#5221
Open
sschuberth wants to merge 1 commit into
Open
Fix the openssl-exception-lgpl-3.0-plus primary spdx_license_key#5221sschuberth wants to merge 1 commit into
openssl-exception-lgpl-3.0-plus primary spdx_license_key#5221sschuberth wants to merge 1 commit into
Conversation
The primary `spdx_license_key` should be the more correct dashed variant, and the other older variant should only be kept for backward compatibility. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
sschuberth
force-pushed
the
fix-lgpl3.0plus-dashes
branch
from
dc7c27e to
e196b9d
Compare
Collaborator
Author
|
Ok, it seems that the original motivation for writing the license name like this is the "spdx_license_key must be 50 characters or less" error 😱 As that restriction seems a bit arbitrary, can we lift it? |
mstykow
added a commit
to mstykow/provenant
that referenced
this pull request
Jul 4, 2026
…cense keys Upstream ScanCode enforces an arbitrary "spdx_license_key must be 50 characters or less" lint that squashed or truncated dozens of LicenseRef-scancode-* SPDX keys (e.g. LicenseRef-scancode-openssl-exception-lgpl3.0plus instead of the canonical ...lgpl-3.0-plus; see aboutcode-org/scancode-toolkit#5221). For the LicenseRef-scancode namespace the identifier is by definition the license key with the namespace prefix, so any deviation is a distortion, not a semantic choice. Provenant applies no length limit, so restore the canonical form at index-build time and keep the previous value in other_spdx_license_keys for backward compatibility. An audit of all 2733 licenses found 50 such deviations: 49 are canonicalized by the general rule; 1 (tgc-spec-license-v2) carries an upstream typo in the license *key* while its SPDX key is already correct (tcg), so it is exempted from the pass (mirroring the key would regress the correct SPDX key, and renaming the key would drop a ScanCode-compatible identifier with no alias mechanism). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
mstykow
added a commit
to mstykow/provenant
that referenced
this pull request
Jul 4, 2026
…cense keys (#1223) Upstream ScanCode enforces an arbitrary "spdx_license_key must be 50 characters or less" lint that squashed or truncated dozens of LicenseRef-scancode-* SPDX keys (e.g. LicenseRef-scancode-openssl-exception-lgpl3.0plus instead of the canonical ...lgpl-3.0-plus; see aboutcode-org/scancode-toolkit#5221). For the LicenseRef-scancode namespace the identifier is by definition the license key with the namespace prefix, so any deviation is a distortion, not a semantic choice. Provenant applies no length limit, so restore the canonical form at index-build time and keep the previous value in other_spdx_license_keys for backward compatibility. An audit of all 2733 licenses found 50 such deviations: 49 are canonicalized by the general rule; 1 (tgc-spec-license-v2) carries an upstream typo in the license *key* while its SPDX key is already correct (tcg), so it is exempted from the pass (mirroring the key would regress the correct SPDX key, and renaming the key would drop a ScanCode-compatible identifier with no alias mechanism). Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Run tests locally to check for errors.