Skip to content

Commit 5b2f22d

Browse files
committed
correct syntax mistake and add tests for rendered html
Signed-off-by: uttam282005 <uttam282005@gmail.com>
1 parent c070d39 commit 5b2f22d

2 files changed

Lines changed: 24 additions & 1 deletion

File tree

scanpipe/templates/scanpipe/project_charts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ <h3 class="title is-4 has-text-centered mb-3">
152152
// Keep in sync with FilterSetUtilsMixin.(empty_value|other_value)
153153
if (name === "(No value detected)") name = "_EMPTY_";
154154
if (name === "Other") name = "_OTHER_";
155-
let full_url = `${base_url}?${field}=${${encodeURIComponent(name)}`;
155+
let full_url = `${base_url}?${field}=${encodeURIComponent(name)}`;
156156
if (in_package) full_url += `&in_package=${in_package}`;
157157
if (event.ctrlKey || event.metaKey) window.open(full_url, '_blank');
158158
else window.location.href = full_url;

scanpipe/tests/test_views.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,18 @@ def test_scanpipe_views_project_details_scan_summary_panels(self):
590590
self.assertContains(response, expected1)
591591
self.assertContains(response, expected2)
592592

593+
def test_scanpipe_views_project_details_scan_summary_language_url_encoding(self):
594+
summary_file = self.project1.get_output_file_path("summary", "json")
595+
scan_summary_json = {
596+
"primary_language": [{"value": "C#", "count": 1}],
597+
"other_languages": [{"value": "C#", "count": 1}],
598+
}
599+
summary_file.write_text(json.dumps(scan_summary_json))
600+
url = self.project1.get_absolute_url()
601+
response = self.client.get(url)
602+
self.assertContains(response, "?programming_language=C%23")
603+
self.assertNotContains(response, "?programming_language=C#")
604+
593605
def test_scanpipe_views_project_details_get_license_clarity_data(self):
594606
get_license_clarity_data = ProjectDetailView.get_license_clarity_data
595607

@@ -1039,6 +1051,17 @@ def test_scanpipe_views_codebase_resource_list_view_bad_search_query(self):
10391051
expected_error = "The provided search value is invalid: No closing quotation"
10401052
self.assertContains(response, expected_error)
10411053

1054+
def test_scanpipe_views_codebase_resource_list_programming_language_url_encoding(
1055+
self,
1056+
):
1057+
make_resource_file(
1058+
self.project1, path="csharp_file.cs", programming_language="C#"
1059+
)
1060+
url = reverse("project_resources", args=[self.project1.slug])
1061+
response = self.client.get(url)
1062+
self.assertContains(response, "?programming_language=C%23")
1063+
self.assertNotContains(response, "?programming_language=C#")
1064+
10421065
def test_scanpipe_views_codebase_resource_details_view_tab_image(self):
10431066
resource1 = make_resource_file(self.project1, "file1.ext")
10441067
response = self.client.get(resource1.get_absolute_url())

0 commit comments

Comments
 (0)