adjust code and fix unit tests

Author: tdruez

scanpipe/templates/scanpipe/includes/vulnerability_id.html

@@ -5,24 +5,26 @@
 {% else %}
   {{ vulnerability.advisory_id }}
 {% endif %}
-<ul class="mb-0">
-  {% for alias in vulnerability.aliases %}
-    <li>
-      {% if alias|slice:":3" == "CVE" %}
-        <a href="https://nvd.nist.gov/vuln/detail/{{ alias }}" target="_blank">{{ alias }}
-          <i class="fa-solid fa-up-right-from-square mini"></i>
-        </a>
-      {% elif alias|slice:":4" == "GHSA" %}
-        <a href="https://github.com/advisories/{{ alias }}" target="_blank">{{ alias }}
-          <i class="fa-solid fa-up-right-from-square mini"></i>
-        </a>
-      {% elif alias|slice:":3" == "NPM" %}
-        <a href="https://github.com/nodejs/security-wg/blob/main/vuln/npm/{{ alias|slice:"4:" }}.json" target="_blank">{{ alias }}
-          <i class="fa-solid fa-up-right-from-square mini"></i>
-        </a>
-      {% else %}
-        {{ alias }}
-      {% endif %}
-    </li>
-  {% endfor %}
-</ul>
+{% if vulnerability.aliases %}
+  <ul class="mb-0">
+    {% for alias in vulnerability.aliases %}
+      <li>
+        {% if alias|slice:":3" == "CVE" %}
+          <a href="https://nvd.nist.gov/vuln/detail/{{ alias }}" target="_blank">{{ alias }}
+            <i class="fa-solid fa-up-right-from-square mini"></i>
+          </a>
+        {% elif alias|slice:":4" == "GHSA" %}
+          <a href="https://github.com/advisories/{{ alias }}" target="_blank">{{ alias }}
+            <i class="fa-solid fa-up-right-from-square mini"></i>
+          </a>
+        {% elif alias|slice:":3" == "NPM" %}
+          <a href="https://github.com/nodejs/security-wg/blob/main/vuln/npm/{{ alias|slice:"4:" }}.json" target="_blank">{{ alias }}
+            <i class="fa-solid fa-up-right-from-square mini"></i>
+          </a>
+        {% else %}
+          {{ alias }}
+        {% endif %}
+      </li>
+    {% endfor %}
+  </ul>
+{% endif %}

scanpipe/templates/scanpipe/tabset/tab_vulnerabilities.html

@@ -13,7 +13,7 @@
     {% for vulnerability in tab_data.fields.affected_by_vulnerabilities.value %}
       <tr>
         <td>
-          {% include 'scanpipe/includes/vulnerability_id.html' with vulnerability=vulnerability VULNERABLECODE_URL=tab_data.VULNERABLECODE_URL %}
+          {% include 'scanpipe/includes/vulnerability_id.html' with vulnerability=vulnerability %}
         </td>
         <td>
           {% include 'scanpipe/includes/vulnerability_summary.html' with vulnerability=vulnerability only %}