Skip to content

Commit dce8dbd

Browse files
authored
feat: remove the need for context processor and improve base template (#2106)
Signed-off-by: tdruez <tdruez@aboutcode.org>
1 parent 903477c commit dce8dbd

28 files changed

+23
-68
lines changed

scancodeio/settings.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@
252252
"django.contrib.auth.context_processors.auth",
253253
"django.contrib.messages.context_processors.messages",
254254
"django.template.context_processors.request",
255-
"scancodeio.context_processors.versions",
256255
],
257256
},
258257
},

scanpipe/templates/account/profile.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
{% block content %}
44
<div class="container is-max-widescreen">
5-
{% include 'scanpipe/includes/navbar_header.html' %}
6-
<div class="mx-5 mb-2">{% include 'scanpipe/includes/messages.html' %}</div>
7-
85
<section class="section pt-0">
96
<div class="is-flex is-justify-content-space-between mb-2">
107
<nav class="breadcrumb is-medium mb-1" aria-label="breadcrumbs">

scanpipe/templates/registration/login.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
{% block content %}
44
<div class="container is-max-widescreen">
5-
{% include 'scanpipe/includes/navbar_header.html' %}
6-
<div class="mx-5 mb-2">{% include 'scanpipe/includes/messages.html' %}</div>
7-
85
{% if form.errors %}
96
<article class="message is-danger">
107
<div class="message-body">

scanpipe/templates/scanpipe/app_monitoring.html

Lines changed: 0 additions & 23 deletions
This file was deleted.

scanpipe/templates/scanpipe/base.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
{% block extrahead %}{% endblock %}
1919
</head>
2020
<body class="pb-5" hx-headers='{"x-csrftoken": "{{ csrf_token }}"}'>
21+
{% block header %}
22+
<div id="header" class="container is-max-widescreen">
23+
{% include 'scanpipe/includes/navbar_header.html' %}
24+
<div class="mx-5 mb-2">{% include 'scanpipe/includes/messages.html' %}</div>
25+
</div>
26+
{% endblock %}
2127
{% block content %}{% endblock %}
2228
{% block modals %}{% endblock %}
2329
{% block scripts %}{% endblock %}

scanpipe/templates/scanpipe/dependency_detail.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
{% block content %}
77
<div class="container is-max-widescreen">
8-
{% include 'scanpipe/includes/navbar_header.html' %}
9-
<div class="mx-5 mb-2">{% include 'scanpipe/includes/messages.html' %}</div>
108
{% include 'scanpipe/includes/breadcrumb_detail_view.html' with object_title=object.package_url url_name="project_dependencies" %}
119
<div class="mx-5">{% include 'scanpipe/tabset/tabset.html' %}</div>
1210
</div>

scanpipe/templates/scanpipe/dependency_list.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
{% block content %}
66
<div id="content-header" class="container is-max-widescreen mb-3">
7-
{% include 'scanpipe/includes/navbar_header.html' %}
87
<section class="mx-5">
98
<div class="is-flex is-justify-content-space-between">
109
{% include 'scanpipe/includes/breadcrumb.html' with linked_project=True current="Dependencies" %}

scanpipe/templates/scanpipe/dependency_tree.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
{% block content %}
1212
<div id="content-header" class="container is-max-widescreen mb-3">
13-
{% include 'scanpipe/includes/navbar_header.html' %}
1413
<section class="mx-5">
1514
<div class="is-flex is-justify-content-space-between">
1615
{% include 'scanpipe/includes/breadcrumb.html' with linked_project=True current="Dependency tree" %}

scanpipe/templates/scanpipe/includes/navbar_header.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
{% load scanpipe_tags %}
2+
{% scancodeio_version_tag as SCANCODEIO_VERSION %}
3+
{% scancode_toolkit_version_tag as SCANCODE_TOOLKIT_VERSION %}
14
<nav class="navbar is-dark mb-4 border-bottom-radius" aria-label="main navigation">
25
<div class="navbar-brand ml-3">
36
<a class="navbar-item is-block is-size-4 has-text-weight-bold" href="/">

scanpipe/templates/scanpipe/license_detail.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
{% block content %}
77
<div class="container is-max-widescreen">
8-
{% include 'scanpipe/includes/navbar_header.html' %}
9-
<div class="mx-5 mb-2">{% include 'scanpipe/includes/messages.html' %}</div>
108
<section class="mx-5 mb-3">
119
<nav class="breadcrumb is-medium has-succeeds-separator mb-1" aria-label="breadcrumbs">
1210
<ul>

0 commit comments

Comments
 (0)