Fix #1802: normalize boolean string values in _clean_package_data#2089
Closed
Monal-Reddy wants to merge 5 commits into
Closed
Fix #1802: normalize boolean string values in _clean_package_data#2089Monal-Reddy wants to merge 5 commits into
Monal-Reddy wants to merge 5 commits into
Conversation
…kage_data and add regression test Signed-off-by: Monal Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Signed-off-by: Monal-Reddy <monalreddy001@gmail.com>
Contributor
Author
|
hi @AyanSinhaMahapatra I was able to reproduce the issue and validate fix locally, I tested it using django shell as running the full pipeline via UI was taking too long. Please review when convenient. |
Contributor
|
This has already been fixed on the toolkit side: aboutcode-org/scancode-toolkit#4631 |
Contributor
Author
|
ok, will check it, thankyou. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Closes: #1802
Changes
Fix an issue where
DiscoveredPackagecreation fails with:ValidationError: "true" value must be either True or False
This occurs when boolean values are provided as strings (
"true"/"false"), which DjangoBooleanFielddoes not accept.The fix normalizes boolean string values in
_clean_package_data()by converting"true"and"false"to their corresponding Python boolean values (True/False) for fields defined asBooleanFieldin theDiscoveredPackagemodel.Tests
Added a regression test in
scanpipe/tests/pipes/test_pipes.pyto ensure boolean string values are normalized correctly.Checklist