fix: Support SQLite in migration 0079_apitoken_data#2110
Closed
Om-A-osc wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Om-A-osc <omanand8132@gmail.com>
d84593d to
ba0ad2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Changes
The migration file scanpipe/migrations/0079_apitoken_data.py was checking if a table existed using PostgreSQL-specific syntax:
This syntax works for PostgreSQL but not for SQLite. SQLite uses a completely different system table called sqlite_master.
I updated the migration to detect which database is being used and use the correct SQL syntax for each:
Checklist