Fix: Workflow errors in test_views.py

Signed-off-by: RISHI GARG <134256793+Rishi-source@users.noreply.github.com>

Author: Rishi-source

vulnerabilities/templates/packages.html

@@ -21,6 +21,9 @@
                 <div class="dropdown is-hoverable">
                     <div class="dropdown-trigger">
                         <button class="button" aria-haspopup="true" aria-controls="dropdown-menu">
+                            <span class="icon is-small">
+                                <i class="fa fa-filter" aria-hidden="true"></i>
+                            </span>
                             <span>
                                 {% if request.GET.vulnerable_only == 'true' %}
                                     Vulnerable Only
@@ -30,9 +33,6 @@
                                     All Packages
                                 {% endif %}
                             </span>
-                            <span class="icon is-small">
-                                <i class="fa fa-filter" aria-hidden="true"></i>
-                            </span>
                         </button>
                     </div>
                     <div class="dropdown-menu" id="dropdown-menu" role="menu">

vulnerabilities/views.py

@@ -49,7 +49,6 @@ def get_context_data(self, **kwargs):
         request_query = self.request.GET
         context["package_search_form"] = PackageSearchForm(request_query)
         context["search"] = request_query.get("search")
-        context["vulnerable_only"] = request_query.get("vulnerable_only", "")
         return context
 
     def get_queryset(self, query=None):
@@ -58,21 +57,25 @@ def get_queryset(self, query=None):
         Make a best effort approach to find matching packages either based
         on exact purl, partial purl or just name and namespace.
         """
-        form = PackageSearchForm(self.request.GET)
-        query = query or self.request.GET.get("search") or ""
-
+        if query is not None:
+            queryset = (
+                self.model.objects.search(query)
+                .with_vulnerability_counts()
+                .prefetch_related()
+                .order_by("package_url")
+            )
+            return queryset
+        query = self.request.GET.get("search") or ""
         queryset = (
             self.model.objects.search(query)
             .with_vulnerability_counts()
             .prefetch_related()
             .order_by("package_url")
         )
-
-        if form.is_valid():
-            vulnerable_only = form.cleaned_data.get("vulnerable_only", "")
-            if vulnerable_only in ["true", "false"]:
-                queryset = queryset.with_is_vulnerable()
-                queryset = queryset.filter(is_vulnerable=vulnerable_only == "true")
+        vulnerable_only = self.request.GET.get("vulnerable_only", "")
+        if vulnerable_only in ["true", "false"]:
+            queryset = queryset.with_is_vulnerable()
+            queryset = queryset.filter(is_vulnerable=vulnerable_only == "true")
 
         return queryset