Skip to content

Commit 184aee8

Browse files
committed
Update the pipeline and fix the test
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
1 parent 4f3b8cd commit 184aee8

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

vulnerabilities/pipelines/v2_improvers/reference_collect_commits.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ def collect_and_store_fix_commits(self):
4545
for adv in progress.iter(affected_advisories.paginated(per_page=500)):
4646
for reference in adv.references.all():
4747
purl = url2purl(reference.url)
48-
if not purl or (purl.type not in VCS_URLS_SUPPORTED_TYPES) or not is_commit(purl.version):
48+
if (
49+
not purl
50+
or (purl.type not in VCS_URLS_SUPPORTED_TYPES)
51+
or not is_commit(purl.version)
52+
):
4953
continue
5054

5155
base_purl = get_core_purl(purl)

vulnerabilities/tests/pipelines/v2_improvers/test_collect_commits_v2.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
# See https://aboutcode.org for more information about nexB OSS projects.
88

99
from datetime import datetime
10+
1011
import pytest
12+
1113
from vulnerabilities.models import AdvisoryReference
1214
from vulnerabilities.models import AdvisoryV2
1315
from vulnerabilities.models import ImpactedPackage
@@ -92,7 +94,9 @@ def test_collect_fix_commits_pipeline_skips_non_commit_urls():
9294
impact = ImpactedPackage.objects.create(advisory=advisory)
9395
impact.affecting_packages.add(package)
9496

95-
reference = AdvisoryReference.objects.create(url="https://github.com/test/testpkg/issues/12") # invalid reference 1
97+
reference = AdvisoryReference.objects.create(
98+
url="https://github.com/test/testpkg/issues/12"
99+
) # invalid reference 1
96100
advisory.references.add(reference)
97101

98102
pipeline = CollectReferencesFixCommitsPipeline()

0 commit comments

Comments
 (0)