Skip to content

Commit 268094f

Browse files
committed
Optimize views
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent fbe5b04 commit 268094f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

vulnerabilities/views.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,18 +210,19 @@ def get_context_data(self, **kwargs):
210210
context["latest_non_vulnerable"] = latest_non_vulnerable
211211
context["package_search_form"] = PackageSearchForm(self.request.GET)
212212

213-
affected_by_advisories = models.AdvisoryV2.objects.latest_affecting_advisories_for_purl(
213+
affected_by_advisories_qs = models.AdvisoryV2.objects.latest_affecting_advisories_for_purl(
214214
package.package_url
215215
)
216216

217-
fixing_advisories = models.AdvisoryV2.objects.latest_fixed_by_advisories_for_purl(
217+
fixing_advisories_qs = models.AdvisoryV2.objects.latest_fixed_by_advisories_for_purl(
218218
package.package_url
219219
)
220220

221221
affected_by_advisories_url = None
222222
fixing_advisories_url = None
223223

224-
if affected_by_advisories.count() > 100:
224+
affected_by_advisories = list(affected_by_advisories_qs[:101])
225+
if len(affected_by_advisories) > 100:
225226
affected_by_advisories_url = reverse_lazy(
226227
"affected_by_advisories_v2", kwargs={"purl": package.package_url}
227228
)
@@ -232,7 +233,7 @@ def get_context_data(self, **kwargs):
232233
else:
233234
fixed_pkg_details = get_fixed_package_details(package)
234235
affected_avid_by_hash = {}
235-
affected_avid_by_hash = group_advisories_by_content(affected_by_advisories)
236+
affected_avid_by_hash = group_advisories_by_content(affected_by_advisories_qs)
236237
affecting_advs = []
237238

238239
for hash in affected_avid_by_hash:
@@ -241,7 +242,8 @@ def get_context_data(self, **kwargs):
241242
context["fixed_package_details"] = fixed_pkg_details
242243
context["affected_by_advisories_v2_url"] = None
243244

244-
if fixing_advisories.count() > 100:
245+
fixing_advisories = list(fixing_advisories_qs[:101])
246+
if len(fixing_advisories) > 100:
245247
fixing_advisories_url = reverse_lazy(
246248
"fixing_advisories_v2", kwargs={"purl": package.package_url}
247249
)
@@ -250,7 +252,7 @@ def get_context_data(self, **kwargs):
250252

251253
else:
252254
fixing_avid_by_hash = {}
253-
fixing_avid_by_hash = group_advisories_by_content(fixing_advisories)
255+
fixing_avid_by_hash = group_advisories_by_content(fixing_advisories_qs)
254256
fixing_advs = []
255257

256258
for hash in fixing_avid_by_hash:

0 commit comments

Comments
 (0)