Fix tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/api_v2.py

@@ -379,7 +379,7 @@ def get_affected_by_vulnerabilities(self, package):
 
         for hash in grouped_advisories:
             advs.append(grouped_advisories[hash])
-        
+
         result = []
 
         for advisory in advs:

vulnerabilities/tests/test_api_v2.py

@@ -850,37 +850,39 @@ def setUp(self):
         )
 
         self.package = PackageV2.objects.from_purl(purl="pkg:pypi/sample@1.0.0")
-        self.impact = ImpactedPackage.objects.create(advisory=self.advisory)
+        self.impact = ImpactedPackage.objects.create(
+            advisory=self.advisory, base_purl="pkg:pypi/sample"
+        )
         self.impact.affecting_packages.add(self.package)
 
         self.client = APIClient(enforce_csrf_checks=True)
 
     def test_list_with_purl_filter(self):
         url = reverse("package-v3-list")
-        with self.assertNumQueries(23):
+        with self.assertNumQueries(29):
             response = self.client.get(url, {"purl": "pkg:pypi/sample@1.0.0"})
         assert response.status_code == 200
         assert "packages" in response.data["results"]
-        assert "advisories" in response.data["results"]
-        assert self.advisory.avid in response.data["results"]["advisories"]
+        assert "advisories_by_id" in response.data["results"]
+        assert self.advisory.avid in response.data["results"]["advisories_by_id"]
 
     def test_bulk_lookup(self):
         url = reverse("package-v3-bulk-lookup")
-        with self.assertNumQueries(22):
+        with self.assertNumQueries(28):
             response = self.client.post(url, {"purls": ["pkg:pypi/sample@1.0.0"]}, format="json")
         assert response.status_code == 200
         assert "packages" in response.data
-        assert "advisories" in response.data
-        assert self.advisory.avid in response.data["advisories"]
+        assert "advisories_by_id" in response.data
+        assert self.advisory.avid in response.data["advisories_by_id"]
 
     def test_bulk_search_plain(self):
         url = reverse("package-v3-bulk-search")
         payload = {"purls": ["pkg:pypi/sample@1.0.0"], "plain_purl": True, "purl_only": False}
-        with self.assertNumQueries(22):
+        with self.assertNumQueries(28):
             response = self.client.post(url, payload, format="json")
         assert response.status_code == 200
         assert "packages" in response.data
-        assert "advisories" in response.data
+        assert "advisories_by_id" in response.data
 
     def test_bulk_search_purl_only(self):
         url = reverse("package-v3-bulk-search")
@@ -892,7 +894,7 @@ def test_bulk_search_purl_only(self):
 
     def test_lookup_single_package(self):
         url = reverse("package-v3-lookup")
-        with self.assertNumQueries(15):
+        with self.assertNumQueries(21):
             response = self.client.post(url, {"purl": "pkg:pypi/sample@1.0.0"}, format="json")
         assert response.status_code == 200
         assert any(pkg["purl"] == "pkg:pypi/sample@1.0.0" for pkg in response.data)

vulnerabilities/views.py

@@ -214,7 +214,6 @@ def get_context_data(self, **kwargs):
         for hash in fixing_avid_by_hash:
             fixing_advs.append(fixing_avid_by_hash[hash])
 
-
         context["package"] = package
         context["next_non_vulnerable"] = next_non_vulnerable
         context["latest_non_vulnerable"] = latest_non_vulnerable