chore: update whisper.cpp submodule to v1.8.2#144
Conversation
|
Thanks @candrews for the PR! Do you happen to know what changed in whisper.cpp between 1.7.6 and 1.8.2 that might affect the build flags or CPU requirements? |
4437279 to
5ffaa55
Compare
5ffaa55 to
ffab241
Compare
|
@absadiki I tracked down the problem - it was really interesting! Whisper.cpp added support for and starting using BMI2 instructions. But they incorrectly set up the build system to use those instructions on 32 bit Windows which doesn't support them, resulting in a compilation failure. I updated this PR to disable BMI2 on Windows as a workaround and submitted a PR upstream to fix the issue: ggml-org/whisper.cpp#3543 The workflows for this PR now pass so I believe it can now be merged. |
|
Yeah, this is really interesting, I wasn’t aware BMI2 was introduced in the newer versions. All workflows now pass, including on windows-latest. Really awesome work tracking this down! I’ll go ahead and merge this and push a new release to PyPI. |
Update whisper.cpp from 1.7.6 to 1.8.2: https://github.com/ggml-org/whisper.cpp/releases
There are a number of useful improvements in these releases, including some significant performance gains.
Can you please make a release of pywhispercpp with this PR merged too?
Thank you!