Change abseil hardening assertions in cleanup from macros to functions

This associates debug information with the assertion sites,
allowing clearer stack-traces for assertion failures and
better accounting of the performance overhead of assertions.

PiperOrigin-RevId: 911622698
Change-Id: If981469b9da24c83a97534db2aa579ee21c9547c

Author: Abseil Team

absl/cleanup/BUILD.bazel

@@ -39,6 +39,7 @@ cc_library(
     linkopts = ABSL_DEFAULT_LINKOPTS,
     deps = [
         "//absl/base:core_headers",
+        "//absl/base:hardening",
         "//absl/utility",
     ],
 )
@@ -54,6 +55,7 @@ cc_library(
         ":cleanup_internal",
         "//absl/base:config",
         "//absl/base:core_headers",
+        "//absl/base:hardening",
     ],
 )
 

absl/cleanup/CMakeLists.txt

@@ -22,6 +22,7 @@ absl_cc_library(
     ${ABSL_DEFAULT_COPTS}
   DEPS
     absl::core_headers
+    absl::hardening
     absl::utility
   PUBLIC
 )
@@ -37,6 +38,7 @@ absl_cc_library(
     absl::cleanup_internal
     absl::config
     absl::core_headers
+    absl::hardening
   PUBLIC
 )
 

absl/cleanup/cleanup.h

@@ -75,6 +75,7 @@
 #include <utility>
 
 #include "absl/base/config.h"
+#include "absl/base/internal/hardening.h"
 #include "absl/base/macros.h"
 #include "absl/cleanup/internal/cleanup.h"
 
@@ -95,12 +96,12 @@ class [[nodiscard]] Cleanup final {
   Cleanup(Cleanup&& other) = default;
 
   void Cancel() && {
-    ABSL_HARDENING_ASSERT(storage_.IsCallbackEngaged());
+    absl::base_internal::HardeningAssert(storage_.IsCallbackEngaged());
     storage_.DestroyCallback();
   }
 
   void Invoke() && {
-    ABSL_HARDENING_ASSERT(storage_.IsCallbackEngaged());
+    absl::base_internal::HardeningAssert(storage_.IsCallbackEngaged());
     storage_.InvokeCallback();
     storage_.DestroyCallback();
   }

absl/cleanup/internal/cleanup.h

@@ -19,6 +19,7 @@
 #include <type_traits>
 #include <utility>
 
+#include "absl/base/internal/hardening.h"
 #include "absl/base/macros.h"
 #include "absl/base/thread_annotations.h"
 #include "absl/utility/utility.h"
@@ -55,7 +56,7 @@ class Storage {
   }
 
   Storage(Storage&& other) {
-    ABSL_HARDENING_ASSERT(other.IsCallbackEngaged());
+    absl::base_internal::HardeningAssert(other.IsCallbackEngaged());
 
     ::new (GetCallbackBuffer()) Callback(std::move(other.GetCallback()));
     is_callback_engaged_ = true;