Add unsigned to character buffers to ensure they can provide storage (https://eel.is/c++draft/intro.object#3)#1860
Add unsigned to character buffers to ensure they can provide storage (https://eel.is/c++draft/intro.object#3)#1860CJ-Johnson wants to merge 7 commits into
unsigned to character buffers to ensure they can provide storage (https://eel.is/c++draft/intro.object#3)#1860Conversation
Remove extraneous formatting changes
Remove extraneous formatting changes
Remove extraneous formatting changes
Remove extraneous formatting changes
Remove extraneous formatting changes
derekmauro
left a comment
There was a problem hiding this comment.
Thanks! This currently doesn't build in any configuration. Can you please try building the code?
|
@derekmauro Thanks for the headsup! I attempted to build it locally but ran into an issue. Basically, my Apple clang/libc++ version is too old, I think. I reinstalled xcode command line tools as well as llvm via homebrew, but the issue persists. You can see the output here: https://pastebin.com/ZV5VJAiR Are you able to share the Kokoro output with me? That way I can see what the actual failure is as opposed to the unrelated issue I see locally. |
|
@derekmauro Actually after updating Xcode and running |
|
@derekmauro Also while I have you, are you able to review and land abseil/abseil.github.io#501 ? Thanks! |
|
Thanks. It was actually easier for me to make the simple fix myself. Merged. For abseil/abseil.github.io#501, I'm going to have to take a look to see what the procedure is to update the documentation. |
|
Awesome thanks! |
I just learned today that
charcannot "provide storage" in the way I previously thought. Onlystd::byteandunsigned charare allowed. So I decided to fix my past mistakes inabsl::InlinedVectorandabsl::Cleanupas well as any others I could find in Abseil. See: https://eel.is/c++draft/intro.object#3