Skip to content

Fix link of MSVC built abseil in Clang/LLVM projects #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mario1159 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −10
Open

Fix link of MSVC built abseil in Clang/LLVM projects #2054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604bdc8
Set ABSL_DEFAULT_LINKOPTS to private to avoid propagating into interf…
Mario1159 May 15, 2026
38736c9
Merge branch 'master' of https://github.com/Mario1159/abseil-cpp
Mario1159 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions CMake/AbseilHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,13 @@ function(absl_cc_library)
set(PC_CFLAGS "${PC_CFLAGS} ${cflag}")
endif()
endforeach()
string(REPLACE ";" " " PC_LINKOPTS "${ABSL_CC_LIB_LINKOPTS}")
# Remove ABSL_DEFAULT_LINKOPTS from ABSL_CC_LIB_LINKOPTS to prevent
# duplication and exportation of linker-only flags.
set(_ABSL_CC_LIB_LINKOPTS "${ABSL_CC_LIB_LINKOPTS}")
foreach(_opt IN LISTS ABSL_DEFAULT_LINKOPTS)
list(REMOVE_ITEM _ABSL_CC_LIB_LINKOPTS "${_opt}")
endforeach()
string(REPLACE ";" " " PC_LINKOPTS "${_ABSL_CC_LIB_LINKOPTS}")
FILE(GENERATE OUTPUT "${CMAKE_BINARY_DIR}/lib/pkgconfig/absl_${_NAME}.pc" CONTENT "\
prefix=${CMAKE_INSTALL_PREFIX}\n\
exec_prefix=\${prefix}\n\
Expand Down Expand Up @@ -238,10 +244,9 @@ Cflags: -I\${includedir}${PC_CFLAGS}\n")
)
target_link_libraries(${_NAME}
PUBLIC ${_dll_deps}
PRIVATE
${ABSL_CC_LIB_LINKOPTS}
${ABSL_DEFAULT_LINKOPTS}
PRIVATE ${_ABSL_CC_LIB_LINKOPTS}
)
target_link_options(${_NAME} PRIVATE ${ABSL_DEFAULT_LINKOPTS})

if (ABSL_CC_LIB_TESTONLY)
set(_gtest_link_define "GTEST_LINKED_AS_SHARED_LIBRARY=1")
Expand All @@ -266,11 +271,10 @@ Cflags: -I\${includedir}${PC_CFLAGS}\n")
INSTALL_RPATH "$ORIGIN")
endif()
target_link_libraries(${_NAME}
PUBLIC ${ABSL_CC_LIB_DEPS}
PRIVATE
${ABSL_CC_LIB_LINKOPTS}
${ABSL_DEFAULT_LINKOPTS}
PUBLIC ${ABSL_CC_LIB_DEPS}
PRIVATE ${_ABSL_CC_LIB_LINKOPTS}
)
target_link_options(${_NAME} PRIVATE ${ABSL_DEFAULT_LINKOPTS})
else()
message(FATAL_ERROR "Invalid build type: ${_build_type}")
endif()
Expand Down Expand Up @@ -337,8 +341,7 @@ Cflags: -I\${includedir}${PC_CFLAGS}\n")
target_link_libraries(${_NAME}
INTERFACE
${ABSL_CC_LIB_DEPS}
${ABSL_CC_LIB_LINKOPTS}
${ABSL_DEFAULT_LINKOPTS}
${_ABSL_CC_LIB_LINKOPTS}
)
target_compile_definitions(${_NAME} INTERFACE ${ABSL_CC_LIB_DEFINES})

Expand Down