Merge pull request #13 from abstractitptyltd/spec_tests

Spec tests

Author: Pete Brown

.editorconfig

@@ -0,0 +1,14 @@
+; This file is for unifying the coding style for different editors and IDEs.
+; Plugins are available for notepad++, emacs, vim, gedit,
+; textmate, visual studio, and more.
+;
+; See http://editorconfig.org for details.
+
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true

.fixtures.yml

@@ -0,0 +1,10 @@
+fixtures:
+  forge_modules:
+    stdlib:
+      repo: "puppetlabs/stdlib"
+      ref:  "4.1.0"
+    concat:
+      repo: "puppetlabs/concat"
+      ref:  "1.2.0"
+  symlinks:
+    sudo: "#{source_dir}"

.gitignore

@@ -1,2 +1 @@
 pkg/
-spec/

.rspec

@@ -0,0 +1,2 @@
+--format documentation
+--color

.travis.yml

@@ -0,0 +1,45 @@
+language: ruby
+sudo: false
+bundler_args: --without development
+before_install: rm Gemfile.lock || true
+rvm:
+- 1.9
+- 2.0
+- 2.1
+script: bundle exec rake test
+env:
+- PUPPET_VERSION="~> 3.6.0" STRICT_VARIABLES=true
+- PUPPET_VERSION="~> 3.7.0" STRICT_VARIABLES=true
+- PUPPET_VERSION="~> 3.8.0" STRICT_VARIABLES=true
+- PUPPET_VERSION="~> 3.8.0" STRICT_VARIABLES=true PARSER="future"
+- PUPPET_VERSION="~> 4.0.0" STRICT_VARIABLES=true
+- PUPPET_VERSION="~> 4.1.0" STRICT_VARIABLES=true
+- PUPPET_VERSION="~> 4.2.0" STRICT_VARIABLES=true
+matrix:
+  exclude:
+  - rvm: 1.9
+    env: PUPPET_VERSION="~> 4.0.0" STRICT_VARIABLES=true
+  - rvm: 1.9
+    env: PUPPET_VERSION="~> 4.1.0" STRICT_VARIABLES=true
+  - rvm: 1.9
+    env: PUPPET_VERSION="~> 4.2.0" STRICT_VARIABLES=true
+  - rvm: 2.0
+    env: PUPPET_VERSION="~> 4.0.0" STRICT_VARIABLES=true
+  - rvm: 2.0
+    env: PUPPET_VERSION="~> 4.1.0" STRICT_VARIABLES=true
+  - rvm: 2.0
+    env: PUPPET_VERSION="~> 4.2.0" STRICT_VARIABLES=true
+notifications:
+  slack:
+    secure: Bgqq8f5Ej+g78Iy8o0HSexx4OyCrO2eNrSiev8O8FCB2zQSNZ82EUnuXwDq5LeHJZb3eTBM/6NcAYeXRNuHwgniQQef9xiHC8uBvV3pMstAe5pa+9l7OaXzKyMrVhbjUfqZUhnRYPHY+OYgUMb4UfotfxvRCduPj1YhMrSVXocs=
+deploy:
+  provider: puppetforge
+  user: abstractit
+  password:
+    secure: ZbtzOD15CmlaLJ0zK2qwLLaqXDk+Ile/2nGwZQ3pV5+cx6ILBVHN/cH0PaddVM9z2bV8k/sHN9ZCe5NXEyC54Vta8jCgLvIckS0tRqNICagn5BMhyEg5jSP7IIDhM9pWgF9KiJyMtx+8iWIt6h7v5+HbOylUuSUyhA0ewpFp2GA=
+  on:
+    tags: true
+    rvm: 2.1
+    condition:
+    - $PUPPET_VERSION = '~> 4.2.0'
+    - $STRICT_VARIABLES = true

.yardopts

@@ -0,0 +1 @@
+--markup markdown

Gemfile

@@ -0,0 +1,31 @@
+source 'https://rubygems.org'
+
+group :test do
+  gem 'rake'
+  gem 'puppet', ENV['PUPPET_VERSION'] || '~> 4.2.0'
+  gem 'puppet-lint', :git =>  'https://github.com/rodjek/puppet-lint'
+  gem 'puppet-lint-unquoted_string-check', :require => false
+  gem 'puppet-lint-empty_string-check', :require => false
+  gem 'puppet-lint-leading_zero-check', :require => false
+  gem 'puppet-lint-variable_contains_upcase', :require => false
+  gem 'puppet-lint-spaceship_operator_without_tag-check', :require => false
+  gem 'puppet-lint-absolute_classname-check', :require => false
+  gem 'puppet-lint-undef_in_function-check', :require => false
+  gem 'puppet-lint-roles_and_profiles-check', :require => false
+  gem "rspec-puppet", :git => 'https://github.com/rodjek/rspec-puppet'#'~> 2.1'
+  gem 'rspec-puppet-facts', :git => 'https://github.com/mcanevet/rspec-puppet-facts',:require => false
+  gem "puppet-syntax"
+  gem 'metadata-json-lint', :require => false
+  gem 'puppetlabs_spec_helper', :git => 'https://github.com/puppetlabs/puppetlabs_spec_helper'
+  gem "rspec", '< 3.2.0'
+  # gem 'coveralls', require: false
+  gem 'pry', '<= 0.9.8'
+  gem "puppet-blacksmith"
+end
+
+group :development do
+  gem 'travis'
+  gem 'travis-lint'
+#  gem "beaker", :git => 'https://github.com/puppetlabs/beaker.git'
+#  gem "beaker-rspec"
+end

Gemfile.lock

@@ -0,0 +1,188 @@
+GIT
+  remote: https://github.com/mcanevet/rspec-puppet-facts
+  revision: dbdf4deda25d03e9a68d462dc5adfc0fda5ab4ca
+  specs:
+    rspec-puppet-facts (1.1.1)
+      facter
+      facterdb (>= 0.2.0)
+      json
+      puppet
+
+GIT
+  remote: https://github.com/puppetlabs/puppetlabs_spec_helper
+  revision: ea5d01fd13aef495b2c7da8e802a3939966f6729
+  specs:
+    puppetlabs_spec_helper (0.10.3)
+      mocha
+      puppet-lint
+      puppet-syntax
+      rake
+      rspec-puppet
+
+GIT
+  remote: https://github.com/rodjek/puppet-lint
+  revision: 2546fed6be894bbcff15c3f48d4b6f6bc15d94d1
+  specs:
+    puppet-lint (1.1.0)
+
+GIT
+  remote: https://github.com/rodjek/rspec-puppet
+  revision: 7659172a5f47c286c03ba6fa76a39cac1087c324
+  specs:
+    rspec-puppet (2.2.1.pre)
+      rspec
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    CFPropertyList (2.2.8)
+    addressable (2.3.8)
+    backports (3.6.6)
+    coderay (1.0.9)
+    diff-lcs (1.2.5)
+    domain_name (0.5.25)
+      unf (>= 0.0.5, < 1.0.0)
+    ethon (0.8.0)
+      ffi (>= 1.3.0)
+    facter (2.4.4)
+      CFPropertyList (~> 2.2.6)
+    facterdb (0.2.1)
+      facter
+      jgrep
+      json
+    faraday (0.9.2)
+      multipart-post (>= 1.2, < 3)
+    faraday_middleware (0.10.0)
+      faraday (>= 0.7.4, < 0.10)
+    ffi (1.9.10)
+    gh (0.14.0)
+      addressable
+      backports
+      faraday (~> 0.8)
+      multi_json (~> 1.0)
+      net-http-persistent (>= 2.7)
+      net-http-pipeline
+    hiera (3.0.1)
+      json_pure
+    highline (1.7.8)
+    http-cookie (1.0.2)
+      domain_name (~> 0.5)
+    jgrep (1.3.3)
+      json
+    json (1.8.3)
+    json_pure (1.8.3)
+    launchy (2.4.3)
+      addressable (~> 2.3)
+    metaclass (0.0.4)
+    metadata-json-lint (0.0.11)
+      json
+      spdx-licenses (~> 1.0)
+    method_source (0.7.1)
+    mime-types (2.6.2)
+    mocha (1.1.0)
+      metaclass (~> 0.0.1)
+    multi_json (1.11.2)
+    multipart-post (2.0.0)
+    net-http-persistent (2.9.4)
+    net-http-pipeline (1.0.1)
+    netrc (0.10.3)
+    pry (0.9.8)
+      coderay (~> 1.0.5)
+      method_source (~> 0.7)
+      slop (>= 2.4.3, < 3)
+    puppet (4.2.2)
+      facter (> 2.0, < 4)
+      hiera (>= 2.0, < 4)
+      json_pure
+    puppet-blacksmith (3.3.1)
+      puppet (>= 2.7.16)
+      rest-client
+    puppet-lint-absolute_classname-check (0.1.3)
+      puppet-lint (~> 1.0)
+    puppet-lint-empty_string-check (0.2.1)
+      puppet-lint (~> 1.0)
+    puppet-lint-leading_zero-check (0.1.0)
+      puppet-lint (~> 1.0)
+    puppet-lint-roles_and_profiles-check (0.1.0)
+      puppet-lint (~> 1.0)
+    puppet-lint-spaceship_operator_without_tag-check (0.1.0)
+      puppet-lint (~> 1.0)
+    puppet-lint-undef_in_function-check (0.1.0)
+      puppet-lint (~> 1.0)
+    puppet-lint-unquoted_string-check (0.2.5)
+      puppet-lint (~> 1.0)
+    puppet-lint-variable_contains_upcase (1.0.0)
+      puppet-lint (~> 1.0)
+    puppet-syntax (2.0.0)
+      rake
+    pusher-client (0.6.2)
+      json
+      websocket (~> 1.0)
+    rake (10.4.2)
+    rest-client (1.8.0)
+      http-cookie (>= 1.0.2, < 2.0)
+      mime-types (>= 1.16, < 3.0)
+      netrc (~> 0.7)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.7)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.1.0)
+    rspec-mocks (3.1.3)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.2)
+    slop (2.4.4)
+    spdx-licenses (1.0.0)
+      json
+    travis (1.8.0)
+      addressable (~> 2.3)
+      backports
+      faraday (~> 0.9)
+      faraday_middleware (~> 0.9, >= 0.9.1)
+      gh (~> 0.13)
+      highline (~> 1.6)
+      launchy (~> 2.1)
+      pry (~> 0.9, < 0.10)
+      pusher-client (~> 0.4)
+      typhoeus (~> 0.6, >= 0.6.8)
+    travis-lint (2.0.0)
+      json
+    typhoeus (0.8.0)
+      ethon (>= 0.8.0)
+    unf (0.1.4)
+      unf_ext
+    unf_ext (0.0.7.1)
+    websocket (1.2.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  metadata-json-lint
+  pry (<= 0.9.8)
+  puppet (~> 4.2.0)
+  puppet-blacksmith
+  puppet-lint!
+  puppet-lint-absolute_classname-check
+  puppet-lint-empty_string-check
+  puppet-lint-leading_zero-check
+  puppet-lint-roles_and_profiles-check
+  puppet-lint-spaceship_operator_without_tag-check
+  puppet-lint-undef_in_function-check
+  puppet-lint-unquoted_string-check
+  puppet-lint-variable_contains_upcase
+  puppet-syntax
+  puppetlabs_spec_helper!
+  rake
+  rspec (< 3.2.0)
+  rspec-puppet!
+  rspec-puppet-facts!
+  travis
+  travis-lint
+
+BUNDLED WITH
+   1.10.6

Rakefile

@@ -0,0 +1,83 @@
+require 'rubygems'
+require 'puppetlabs_spec_helper/rake_tasks'
+require 'puppet-lint/tasks/puppet-lint'
+require 'metadata-json-lint/rake_task'
+require 'puppet-syntax/tasks/puppet-syntax'
+
+begin
+  require 'puppet_blacksmith/rake_tasks'
+rescue LoadError
+end
+
+PuppetLint.configuration.fail_on_warnings = true
+PuppetLint.configuration.relative = true
+PuppetLint.configuration.send('disable_80chars')
+PuppetLint.configuration.send('disable_class_inherits_from_params_class')
+# PuppetLint.configuration.send('disable_class_parameter_defaults')
+PuppetLint.configuration.send('disable_documentation')
+PuppetLint.configuration.send('disable_single_quote_string_with_variables')
+PuppetLint.configuration.log_format = "%{path}:%{linenumber}:%{check}:%{KIND}:%{message}"
+
+PuppetLint.configuration.send('disable_selector_inside_resource')
+PuppetLint.configuration.send('disable_empty_string_assignment')
+
+exclude_paths = [
+  "pkg/**/*",
+  "vendor/**/*",
+  "spec/**/*",
+]
+
+PuppetLint.configuration.ignore_paths = exclude_paths
+PuppetSyntax.exclude_paths = exclude_paths
+
+desc "Populate CONTRIBUTORS file"
+task :contributors do
+  system("git log --format='%aN' | sort -u > CONTRIBUTORS")
+end
+
+task :metadata do
+  sh "bundle exec metadata-json-lint metadata.json"
+end
+
+desc "Validate manifests, templates, and ruby files in lib."
+task :validate do
+  Dir['manifests/**/*.pp'].each do |manifest|
+    sh "puppet parser validate --noop #{manifest}"
+  end
+  Dir['lib/**/*.rb'].each do |lib_file|
+    sh "ruby -c #{lib_file}"
+  end
+  Dir['templates/**/*.erb'].each do |template|
+    sh "erb -P -x -T '-' #{template} | ruby -c"
+  end
+end
+
+desc "Run syntax, lint, and spec tests."
+task :test => [
+  :syntax,
+  :validate,
+  :lint,
+  :spec,
+  :metadata,
+]
+
+if RUBY_VERSION >= "2.1.0" then
+  Blacksmith::RakeTask.new do |t|
+    t.build = false # do not build the module nor push it to the Forge
+    # just do the tagging [:clean, :tag, :bump_commit]
+  end
+
+  desc "Offload release process to Travis."
+  task :travis_release => [
+    :check_changelog,  # check that the changelog contains an entry for the current release
+    :"module:release", # do everything except build / push to forge, travis will do that for us
+  ]
+
+  desc "Check Changelog."
+  task :check_changelog do
+    v = Blacksmith::Modulefile.new.version
+    if File.readlines('CHANGELOG.md').grep("Releasing #{v}").size == 0 then
+      fail "Unable to find a CHANGELOG.md entry for the #{v} release."
+    end
+  end
+end