This repository was archived by the owner on Jul 6, 2025. It is now read-only.
Export include directory when using Easylogging++ as a static library (Fix for #621)#646
Open
MaxSavenkov wants to merge 2 commits into
Open
Export include directory when using Easylogging++ as a static library (Fix for #621)#646MaxSavenkov wants to merge 2 commits into
MaxSavenkov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the Easylogging++ more usable as a static library: now, the user can just add it as a sub-directory to his CMakeLists.txt and then user target_link_libraries( target_name easyloggingpp ) to both link the library to his project and add an include directory.
Also, I removed useless include_directories command which used a directory which (no longer?) exists.
The change only affects build system, and only for the case where build_static_lib flag is ON. It, however, requires a newer version of CMake (at least 2.8.11). I tested it with CMake 3.11, and it worked.