fix: enable skipped failure_memory tests and fix assertion bugs#128
Closed
acailic wants to merge 1 commit into
Closed
fix: enable skipped failure_memory tests and fix assertion bugs#128acailic wants to merge 1 commit into
acailic wants to merge 1 commit into
Conversation
The test suite for collector/failure_memory.py was entirely skipped with 'Feature 2 not yet implemented', but the feature has been implemented. This commit: - Removes the pytestmark skip decorator so all 12 tests now run - Removes local placeholder class definitions (EmbeddingGenerationError, FailureSignature, SimilarFailureMatch) and imports the real ones from collector.failure_memory, so isinstance assertions work correctly - Fixes add_args[1]["metadata"] -> add_args[1]["metadatas"][0] to match the implementation's keyword argument name (plural "metadatas") - Fixes update_args[1]["metadata"] -> update_args[1]["metadatas"][0] for the same reason Closes #127 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Superseded — main deleted tests/test_feature_2_failure_memory.py in 0d4c5e3 (refactor: remove dead ranking module and unused feature tests). This PR modifies a file that no longer exists. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytestmark = pytest.mark.skipfromtests/test_feature_2_failure_memory.py— the feature is fully implemented incollector/failure_memory.py; all 12 tests were silently not runningEmbeddingGenerationError,FailureSignature,SimilarFailureMatch) that duplicated the real implementations; imports the real classes soisinstanceassertions work correctlyadd_args[1]["metadata"]→add_args[1]["metadatas"][0]andupdate_args[1]["metadata"]→update_args[1]["metadatas"][0]to match the implementation's kwargmetadatas(plural)Closes #127
Test plan
test_feature_2_failure_memory.pytests now passruff check .cleantest_baseline.pyor other targeted suites🤖 Generated with Claude Code