fix: enable failure_memory tests and fix assertions (#127)#129
Closed
acailic wants to merge 1 commit into
Closed
Conversation
- Remove pytestmark skip; feature is fully implemented in collector/failure_memory.py - Replace local placeholder classes with real imports from collector.failure_memory - Fix metadata key: `metadata` -> `metadatas[0]` to match vector_db.add/update call signatures Closes #127 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytestmark = pytest.mark.skipthat was incorrectly blocking all tests intests/test_feature_2_failure_memory.py— the feature is fully implemented incollector/failure_memory.pyEmbeddingGenerationError,FailureSignature,SimilarFailureMatch) with real imports fromcollector.failure_memory, fixingisinstanceassertionsadd_args[1]["metadata"]→add_args[1]["metadatas"][0]andupdate_args[1]["metadata"]→update_args[1]["metadatas"][0]to match the implementation's use of the pluralmetadatas=kwargTest plan
python3 -m pytest -q tests/test_feature_2_failure_memory.py)ruff check .passes with no errorsCloses #127
🤖 Generated with Claude Code