build: make OpenSSL pkg-config flags drive header checks and link flags#2686
Open
twz123 wants to merge 1 commit into
Open
build: make OpenSSL pkg-config flags drive header checks and link flags#2686twz123 wants to merge 1 commit into
twz123 wants to merge 1 commit into
Conversation
The OpenSSL detection in configure.ac performed header probes before pkg-config and only propagated the transient LIBS from AC_CHECK_LIB to KA_LIBS. This causes OpenSSL auto-detection to fail when it is in a nonstandard prefix, even though pkg-config knows the correct paths. Run pkg-config before the OpenSSL probes. For the header checks, temporarily add OPENSSL_CPPFLAGS to CPPFLAGS and record OPENSSL_CFLAGS in KA_CFLAGS. For linking, use OPENSSL_LIBS directly in KA_LIBS. When only EVP is needed, add OPENSSL_LIBS without -lssl. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenSSL detection in configure.ac performed header probes before pkg-config and only propagated the transient LIBS from AC_CHECK_LIB to KA_LIBS. This causes OpenSSL auto-detection to fail when it is in a nonstandard prefix, even though pkg-config knows the correct paths.
Run pkg-config before the OpenSSL probes. For the header checks, temporarily add OPENSSL_CPPFLAGS to CPPFLAGS and record OPENSSL_CFLAGS in KA_CFLAGS. For linking, use OPENSSL_LIBS directly in KA_LIBS. When only EVP is needed, add OPENSSL_LIBS without -lssl.