rename SC_LOG macros#166
Open
markfoodyburton wants to merge 1 commit into
Open
Conversation
…o family The merged sc_log proposal introduced a parallel scoped enum (sc_core::sc_log_level) and a convenience-macro family that borrowed SystemC's reserved vocabulary (SC_INFO/SC_DEBUG collide with sc_severity and sc_verbosity enumerators; SC_TRACE is confusable with sc_trace()). This change: - Removes sc_log_level entirely. Logging levels are now sc_core::sc_verbosity values on a clean 100-step scale. - Makes sc_verbosity int-backed (enum sc_verbosity : int) so SC_LOG_AT accepts any integer level with a well-defined conversion, and keeps SC_UNSET (= INT_MAX) as an internal "not-yet-resolved" sentinel rather than an enumerator in the standard enum. - Renames the convenience macros to collision-free, significance-ordered names: SC_CRITICAL (SC_LOW), SC_ALERT (SC_MEDIUM), SC_NOTE (SC_HIGH), SC_DETAIL (SC_FULL), SC_INTERNAL (SC_DEBUG). - Drops the level->text map from core; textual level names are an SCP convenience layered on top. - Updates the dynamic-verbosity callback in sc_simcontext to sc_verbosity. - Updates sc_log test01/test02 (local name maps) and regenerates goldens. Signed-off-by: Mark Burton <mburton@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sc_log: drop sc_log_level, drive macros off sc_verbosity, rename macro family