Add instrumentation/DAQ event types to CTXP examples + linter#2
Merged
Conversation
Adds three new event types for representing user-generated ACT-CAP/DAQ
messages, reusing existing CTXP events where the semantics match:
- DAQ_DATA: captured data value and/or packed {context, DirectData} tag
- DAQ_COUNTER: performance/threshold counter readout
- DAQ_LAST_PC: previous PC before exception/interrupt
ctxp_lint.py learns the three types; EVENT_PAYLOAD_KIND now supports an
optional value1 (None) for DAQ_DATA. Adds examples/daq.* (trace, source,
elf, dis, explanation) and lists the new types/example in README.adoc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Refines the DAQ representation after review: - MEMREAD_1/2/4/8 and MEMWRITE_1/2/4/8 may omit the address (value-only capture): empty value1 in text, reserved sentinel 0xFFFFFFFFFFFFFFFF in binary. The native DATA command maps here instead of to DAQ_DATA. - DAQ_DATA is now a bare 24-bit DirectData tag carrier; size lives in the MEMREAD_N/MEMWRITE_N suffix and direction in the type name, so the Dtype/DSize re-encoding was redundant and is dropped. Linter: MEM_1/2/4/8 value1 optional, DAQ_DATA -> (False,True). Example trace and explanation reworked; README notes the optional address. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reframe daq.ctxp.txt/daq.md around three configured watchpoints/probes that demonstrate the four building blocks of DAQ output: a PC sample (SYNC), a captured data access (MEMWRITE), the last PC before a trap (DAQ_LAST_PC + SYNC), and the DirectData tag used as a probe id (DAQ_DATA). Emphasizes that DAQ output depends on how the instrumentation is configured. Other commands (value-only/address-only captures, counters) are noted with short snippets + pointer to the spec mapping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new event types for representing user-generated ACT-CAP/DAQ messages, reusing existing CTXP events where the semantics match:
ctxp_lint.py learns the three types; EVENT_PAYLOAD_KIND now supports an optional value1 (None) for DAQ_DATA. Adds examples/daq.* (trace, source, elf, dis, explanation) and lists the new types/example in README.adoc.